Skip to content

Conversation

@Funatiq
Copy link
Collaborator

@Funatiq Funatiq commented Oct 23, 2025

  • Updated pre-commit configuration and pyproject.toml for improved file inclusion.
  • Removed exclusions from pyproject.toml related to isort, yapf and autoflake.
  • Instead, explicitly specified the files to be included in the isort, yapf and autoflake hooks in pre-commit config.
  • Updated ruff settings to exclude the files that are already linted by isort, yapf and autoflake.

@coderabbitai summary

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@Funatiq Funatiq changed the title [feat] Use ruff for formatting and linting new files by default [None][feat] Use ruff for formatting and linting new files by default Oct 24, 2025
@Funatiq
Copy link
Collaborator Author

Funatiq commented Oct 24, 2025

/bot run --skip "No tests needed, release check is enough"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22434 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: No tests needed, release check is enough

"tensorrt_llm/_torch/pyexecutor/sampler.py",
"tensorrt_llm/_torch/pyexecutor/sampling_utils.py",
]
exclude = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can / should we leave a comment here reminding devs to keep this in sync with what's in .pre-commit-config.yaml?

Copy link
Collaborator Author

@Funatiq Funatiq Oct 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I added a comment in both files.

@@ -4,6 +4,1391 @@ repos:
rev: 5.12.0
hooks:
- id: isort
files: |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the same set of files for all 3 hooks, would it be possible to ensure they stay in sync using YAML anchors? Something like:

common-files: &common_files |
  (?x)^(
    'file1.py' |
    'file2.py'
  )$

repos:
-   repo: https://github.com/pycqa/isort
    rev: 5.12.0
    hooks:
    -   id: isort
        files: *common_files

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know how to do that. Seems to work fine.

@Funatiq
Copy link
Collaborator Author

Funatiq commented Oct 26, 2025

/bot run skip --comment "No tests needed, release check is enough"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22533 Bot args parsing error: usage: /bot [-h]
{run,kill,skip,submit,reviewers,reuse-pipeline,reuse-review} ...
/bot: error: unrecognized arguments: skip --comment No tests needed, release check is enough

@Funatiq
Copy link
Collaborator Author

Funatiq commented Oct 26, 2025

/bot skip --comment "No tests needed, release check is enough"

- Updated pre-commit configuration and pyproject.toml for improved file inclusion.
- Removed exclusions from `pyproject.toml` related to `isort`, `yapf` and `autoflake`.
- Instead, explicitly specified the files to be included in the `isort`, `yapf` and `autoflake` hooks in pre-commit config.
- Updated `ruff` settings to exclude the files that are already linted by `isort`, `yapf` and `autoflake`.

Signed-off-by: Robin Kobus <[email protected]>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22534 [ skip ] triggered by Bot. Commit: 432d4aa

@Funatiq
Copy link
Collaborator Author

Funatiq commented Oct 26, 2025

/bot skip --comment "No tests needed, release check is enough"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22537 [ skip ] triggered by Bot. Commit: 3888f06

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22534 [ skip ] completed with state ABORTED. Commit: 432d4aa

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22537 [ skip ] completed with state SUCCESS. Commit: 3888f06
Skipping testing for commit 3888f06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants