Skip to content

Conversation

@hchings
Copy link
Collaborator

@hchings hchings commented Oct 24, 2025

Summary by CodeRabbit

  • Refactor
    • Optimized request submission to operate non-blocking, improving system responsiveness and throughput efficiency when processing multiple concurrent requests in the execution layer.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@hchings hchings requested a review from Superjomn October 24, 2025 00:29
@hchings hchings self-assigned this Oct 24, 2025
@hchings hchings requested a review from a team as a code owner October 24, 2025 00:29
@hchings
Copy link
Collaborator Author

hchings commented Oct 24, 2025

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

📝 Walkthrough

Walkthrough

The RayExecutor.submit method is modified to invoke enqueue_request with async_call=True instead of False, changing the request enqueueing from blocking to non-blocking behavior while maintaining existing result handling.

Changes

Cohort / File(s) Change Summary
RayExecutor async behavior modification
tensorrt_llm/executor/ray_executor.py
Changed enqueue_request parameter from async_call=False to async_call=True in RayExecutor.submit

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is substantially incomplete and consists primarily of unfilled template placeholder content. While the description contains the required section headings (Description, Test Coverage, PR Checklist), all substantive content sections remain as template comments without any actual information. The author has not provided an explanation of the issue being fixed, listed any relevant tests, or completed the checklist items. The description needs to be filled out with concrete details about why this change is necessary and what testing supports it. The author should complete the PR description by: providing a brief explanation of the problem and why changing to async RPC is the solution, listing the specific test(s) that validate this change, and completing the PR checklist by confirming that the code follows guidelines, appropriate tests are provided, and other required items have been addressed. This will ensure reviewers have sufficient context to understand and properly evaluate the change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][fix] Change Ray submit() to use async RPC" follows the required template format and clearly summarizes the primary change. The title directly corresponds to the code modification in tensorrt_llm/executor/ray_executor.py where the enqueue_request call now uses async_call=True instead of False. The wording is concise, specific, and allows reviewers scanning the history to quickly understand that this change converts the Ray submit() method to use asynchronous RPC calls.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2392022 and cfbf858.

📒 Files selected for processing (1)
  • tensorrt_llm/executor/ray_executor.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tensorrt_llm/executor/ray_executor.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tensorrt_llm/executor/ray_executor.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tensorrt_llm/executor/ray_executor.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tensorrt_llm/executor/ray_executor.py (1)

208-212: Code change is correct—error handling properly deferred to result access.

The async enqueue design is intentional and well-supported. Errors from enqueue_request on workers are captured in responses sent back via result_wait_queue, then processed asynchronously through GenerationResult.process_response() which invokes background_error_handler(). This pattern is consistent across proxy.py, base_worker.py, and rpc_proxy.py, confirming the infrastructure is in place.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22333 [ run ] triggered by Bot. Commit: cfbf858

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22333 [ run ] completed with state SUCCESS. Commit: cfbf858
/LLM/main/L0_MergeRequest_PR pipeline #16837 completed with status: 'FAILURE'

Copy link
Collaborator

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hchings hchings force-pushed the fix_ray branch 3 times, most recently from 831f26d to 2625c99 Compare October 24, 2025 15:52
@hchings
Copy link
Collaborator Author

hchings commented Oct 24, 2025

/bot run

@hchings hchings enabled auto-merge (squash) October 24, 2025 15:53
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22452 [ run ] triggered by Bot. Commit: 2625c99

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22452 [ run ] completed with state SUCCESS. Commit: 2625c99
/LLM/main/L0_MergeRequest_PR pipeline #16920 completed with status: 'FAILURE'

@hchings
Copy link
Collaborator Author

hchings commented Oct 24, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22463 [ run ] triggered by Bot. Commit: 4e68553

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22463 [ run ] completed with state SUCCESS. Commit: 4e68553
/LLM/main/L0_MergeRequest_PR pipeline #16930 completed with status: 'FAILURE'

@hchings
Copy link
Collaborator Author

hchings commented Oct 26, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22526 [ run ] triggered by Bot. Commit: 940ebb1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22526 [ run ] completed with state SUCCESS. Commit: 940ebb1
/LLM/main/L0_MergeRequest_PR pipeline #16981 completed with status: 'FAILURE'

@hchings
Copy link
Collaborator Author

hchings commented Oct 26, 2025

/bot run

Signed-off-by: Erin Ho <[email protected]>
@hchings
Copy link
Collaborator Author

hchings commented Oct 27, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22575 [ run ] triggered by Bot. Commit: de29065

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22575 [ run ] completed with state SUCCESS. Commit: de29065
/LLM/main/L0_MergeRequest_PR pipeline #17019 completed with status: 'FAILURE'

@hchings
Copy link
Collaborator Author

hchings commented Oct 27, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22671 [ run ] triggered by Bot. Commit: de29065

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22671 [ run ] completed with state SUCCESS. Commit: de29065
/LLM/main/L0_MergeRequest_PR pipeline #17091 completed with status: 'SUCCESS'

@hchings hchings merged commit a966644 into NVIDIA:main Oct 28, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants