Skip to content

Conversation

@QiJune
Copy link
Collaborator

@QiJune QiJune commented Oct 24, 2025

Summary by CodeRabbit

  • Chores
    • Updated test configuration and GPU allocation for post-merge testing scenarios
    • Optimized test split distribution for improved testing efficiency

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@QiJune QiJune requested review from a team as code owners October 24, 2025 07:11
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

📝 Walkthrough

Walkthrough

Jenkins pipeline configuration and GPU test database updated to optimize DGX H100 testing. The DGX H100 PyTorch DeepSeek stage split count reduced from 2 to 1, a new post-merge stage variant added, and four benchmark tests migrated from pre-merge to post-merge execution with GPU constraints.

Changes

Cohort / File(s) Summary
Jenkins Pipeline Configuration
jenkins/L0_Test.groovy
Reduced split count from 2 to 1 for DGX_H100-4_GPUs-PyTorch-DeepSeek x86 test configuration. Added new DGX_H100-4_GPUs-PyTorch-DeepSeek-Post-Merge-1 stage entry with 1 split and 4 GPUs for post-merge testing.
GPU Test Database
tests/integration/test_lists/test-db/l0_dgx_h100.yml
Migrated four disaggregated_benchmark_on_diff_backends tests from pre_merge to post_merge condition block with GPU constraints (gte: 4, lte: 4 for h100 on Ubuntu). Configured post-merge block with pytorch backend, deepseek auto-trigger, and mpi orchestrator.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The PR description is largely incomplete and consists primarily of the template structure with unfilled content. While the PR title indicates the intent to "move some time-consuming benchmark test cases to post merge," the core sections required by the template are empty: the Description section provides no explanation of the issue or solution, the Test Coverage section lists no relevant tests, and the PR Checklist items lack individual confirmations. Although the final generic checkbox is marked, the specific items addressing coding guidelines compliance, test cases, dependency scanning, and CODEOWNERS updates are not checked, leaving critical context about the changes missing. The author should provide a substantive Description section explaining why these test cases are being moved to post-merge and the expected benefits, list the specific test cases affected (DeepSeek-V3-Lite-bf16, llama-v3-8b-hf, llama-3.1-8b-instruct-hf-fp8, and DeepSeek-V3-Lite-fp8 based on the code changes), and explicitly check the relevant PR Checklist items confirming they have reviewed the coding guidelines, considered test coverage implications, and verified appropriate reviewers are assigned.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[None][ci] move some time-consuming benchmark test cases to post merge" directly aligns with the main changes in the changeset. The changes involve moving benchmark test cases from pre-merge to post-merge configuration blocks and adding new post-merge test entries to both the L0_Test.groovy and l0_dgx_h100.yml files. The title is concise, specific, and clearly conveys the primary change from the developer's perspective without unnecessary noise or vague terms.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QiJune
Copy link
Collaborator Author

QiJune commented Oct 24, 2025

/bot run --stage-list "DGX_H100-4_GPUs-PyTorch-DeepSeek-1,DGX_H100-4_GPUs-PyTorch-DeepSeek-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22401 [ run ] triggered by Bot. Commit: b4defd6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22401 [ run ] completed with state SUCCESS. Commit: b4defd6
/LLM/main/L0_MergeRequest_PR pipeline #16884 (Partly Tested) completed with status: 'FAILURE'

@QiJune
Copy link
Collaborator Author

QiJune commented Oct 27, 2025

/bot skip --comment "the refactored stages are launched successfully"

@QiJune QiJune requested a review from chzblych October 27, 2025 01:54
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22549 [ skip ] triggered by Bot. Commit: b4defd6

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22549 [ skip ] completed with state SUCCESS. Commit: b4defd6
Skipping testing for commit b4defd6

Signed-off-by: junq <[email protected]>
Signed-off-by: junq <[email protected]>
@QiJune
Copy link
Collaborator Author

QiJune commented Oct 27, 2025

/bot skip --comment "trivial changes"

@QiJune QiJune enabled auto-merge (squash) October 27, 2025 02:23
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22556 [ skip ] triggered by Bot. Commit: 924609f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22556 [ skip ] completed with state SUCCESS. Commit: 924609f
Skipping testing for commit 924609f

@QiJune QiJune merged commit cc5b8b6 into NVIDIA:main Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants