[https://nvbugs/5607238][test] fix working dir in disagg worker test

[zhengd-nv]

Summary by CodeRabbit

• Tests
  • Updated test infrastructure for improved initialization and working directory handling.

Description

The testing process didn't update the working directory, so the tokenizer used in tests is downloaded from HF instead of locally cached and sym-linked in llm_venv. This PR corrects this behavior and remove a previous workaround for it.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[zhengd-nv]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated KvCacheEventWorkerTester initialization to use model_name directly for tokenizer loading instead of deriving model_path. Removed the optional model_path parameter from the constructor and adjusted working directory handling in background worker setup.

Changes

Cohort / File(s)	Summary
Test worker setup simplification tests/integration/defs/disaggregated/test_workers.py	Removed model_path parameter from KvCacheEventWorkerTester.__init__; tokenizer initialization now uses model_name directly. Added os.chdir(cwd) call in background worker setup and removed redundant per-call os.chdir in kv_cache_aware_router_deepseek_v3_lite_bf16 test.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[https://nvbugs/5607238][test] fix working dir in disagg worker test" follows the required template format with a valid NVBugs ticket reference, a descriptive type indicator, and a clear summary. The title accurately captures the main change in the changeset: fixing the working directory issue in the disaggregated worker test, which aligns directly with the modifications shown in the raw summary (adding os.chdir() call in background_workers and removing the model_path parameter). The title is concise and specific enough for teammates to understand the primary change when scanning history.
Description Check	✅ Passed	The PR description provides a clear and specific explanation of both the issue and solution in the Description section, noting that the working directory wasn't being updated and explaining how the PR corrects this behavior and removes a prior workaround. The PR Checklist section is completed with the confirmation checkbox marked. However, the Test Coverage section remains empty with only placeholder comments and no actual test information provided. While this missing section is a gap in documentation, the core description is substantive and well-explained, meeting the threshold of being "mostly complete" as specified in the evaluation criteria.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 602b059 and b091a99.

📒 Files selected for processing (1)

• tests/integration/defs/disaggregated/test_workers.py (2 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

• tests/integration/defs/disaggregated/test_workers.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

• tests/integration/defs/disaggregated/test_workers.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

• tests/integration/defs/disaggregated/test_workers.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (3)

tests/integration/defs/disaggregated/test_workers.py (3)

210-210: LGTM! Tokenizer now uses model_name directly.

This change correctly removes the model_path workaround. With the working directory properly set in background_workers (line 487), AutoTokenizer.from_pretrained(model_name) will find the locally symlinked model instead of downloading from Hugging Face.

---

487-487: LGTM! This is the key fix for the working directory issue.

Setting the working directory early ensures that when AutoTokenizer.from_pretrained(model_name) is called in KvCacheEventWorkerTester.__init__ (line 210), it will look in the correct location for the locally symlinked model files instead of downloading from Hugging Face.

---

207-207: Parameter removal verified—no external callers affected.

The single instantiation of KvCacheEventWorkerTester at line 559 passes only positional arguments (ctx_servers, gen_servers) and does not reference model_path. No other test files invoke this class with the removed parameter. The breaking change is safe.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #22429 [ run ] triggered by Bot. Commit: b091a99

[tensorrt-cicd]

PR_Github #22429 [ run ] completed with state SUCCESS. Commit: b091a99
/LLM/main/L0_MergeRequest_PR pipeline #16903 completed with status: 'FAILURE'

[zhengd-nv]

/bot run

[tensorrt-cicd]

PR_Github #22550 [ run ] triggered by Bot. Commit: 55e34f8

[tensorrt-cicd]

PR_Github #22550 [ run ] completed with state SUCCESS. Commit: 55e34f8
/LLM/main/L0_MergeRequest_PR pipeline #16998 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

[zhengd-nv]

/bot run --add-multi-gpu-test

[tensorrt-cicd]

PR_Github #22581 [ run ] triggered by Bot. Commit: c43ee2d

[tensorrt-cicd]

PR_Github #22581 [ run ] completed with state SUCCESS. Commit: c43ee2d
/LLM/main/L0_MergeRequest_PR pipeline #17024 completed with status: 'FAILURE'

[zhengd-nv]

/bot run --add-multi-gpu-test

[tensorrt-cicd]

PR_Github #22611 [ run ] triggered by Bot. Commit: c43ee2d

[tensorrt-cicd]

PR_Github #22611 [ run ] completed with state SUCCESS. Commit: c43ee2d
/LLM/main/L0_MergeRequest_PR pipeline #17044 completed with status: 'FAILURE'

[zhengd-nv]

/bot run --add-multi-gpu-test

[tensorrt-cicd]

PR_Github #22640 [ run ] triggered by Bot. Commit: c43ee2d

[tensorrt-cicd]

PR_Github #22640 [ run ] completed with state SUCCESS. Commit: c43ee2d
/LLM/main/L0_MergeRequest_PR pipeline #17066 completed with status: 'FAILURE'

[zhengd-nv]

/bot run --add-multi-gpu-test

[tensorrt-cicd]

PR_Github #22706 [ run ] triggered by Bot. Commit: c43ee2d

[tensorrt-cicd]

PR_Github #22706 [ run ] completed with state SUCCESS. Commit: c43ee2d
/LLM/main/L0_MergeRequest_PR pipeline #17122 completed with status: 'SUCCESS'