[None][infra] User/yuanjingx/choose repo when generate lock files

[yuanjingx87]

Summary by CodeRabbit

• New Features

  • Extended pipeline capabilities to support dynamic repository selection, including custom repositories, and configurable branch parameters for lock file generation workflows

• Chores

  • Updated build environment configuration to properly exclude security-related file patterns from code quality checks

Description

Allow user to generate lock files for gitlab, or a customized repo.
Skip codespell check in precommit hook for lock files and pyproject.toml files

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

Pre-commit configuration adds an ignore pattern for security_scanning/* files to the codespell hook. Jenkins pipeline refactors parameter handling to support dynamic repository URL selection with fallback for custom repositories and renames branch parameter from llmBranch to branchName across all Git operations.

Changes

Cohort / File(s)	Summary
Pre-commit configuration .pre-commit-config.yaml	Extended codespell hook arguments with additional ignore pattern for security_scanning/* files
Jenkins pipeline parameters and operations jenkins/GenerateLock.groovy	Updated pipeline parameters: renamed llmBranch to branchName, added repoUrl choice parameter with predefined options and customRepoUrl for custom repositories. Modified LLM_REPO initialization to use params.repoUrl with conditional fallback to params.customRepoUrl. Updated all Git operations (fetch, rebase, push) to reference params.branchName

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title follows the correct format specified in the repository template: [None][infra] User/yuanjingx/choose repo when generate lock files. It is directly related to the main change in the changeset, which allows users to select different repositories (GitHub, GitLab, or custom) when generating lock files through the Jenkins pipeline (jenkins/GenerateLock.groovy). The title is specific, concise, and clearly communicates the primary objective from the developer's perspective. The supporting change to the pre-commit configuration is a secondary modification.
Description Check	✅ Passed	The pull request description is mostly complete and follows the repository template structure with the main sections present. The Description section is well-articulated, clearly explaining both the primary objective (allowing users to generate lock files for GitLab or custom repositories) and the supporting change (skipping codespell checks for lock files and pyproject.toml). However, the Test Coverage section is entirely empty with no tests listed, and the PR Checklist has no items marked as complete, which leaves some uncertainty about whether the changes have been adequately tested.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02081e2 and 5c032e7.

📒 Files selected for processing (2)

• .pre-commit-config.yaml (1 hunks)
• jenkins/GenerateLock.groovy (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (4)

.pre-commit-config.yaml (1)

69-69: Verify that all intended skip patterns are included.

The PR objectives state: "Skip codespell check in pre-commit hook for lock files and pyproject.toml files." However, the change only adds security_scanning/* to the skip patterns. Lock files and pyproject.toml are not included in this modification.

Confirm whether the intended skip patterns for lock files (e.g., *.lock, poetry.lock, package-lock.json) and pyproject.toml should also be added, or if this change is intentionally focused only on the security_scanning/ directory.

jenkins/GenerateLock.groovy (3)

46-49: LGTM! Clean repository URL selection logic.

The conditional assignment correctly handles the custom repository fallback when "Custom Repo" is selected.

---

72-75: LGTM! Git operations correctly use the renamed parameter.

The fetch, rebase, and push operations all consistently reference params.branchName, which aligns with the parameter rename.

---

87-89: LGTM! Clear parameter definitions.

The parameter declarations provide appropriate defaults and clear descriptions that guide users through the repository selection options.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}