Skip to content

Conversation

@achartier
Copy link
Collaborator

@achartier achartier commented Oct 24, 2025

Summary by CodeRabbit

  • New Features
    • Added Ray orchestrator support for LLM inference, enabling distributed model execution.
    • Extended command-line interface to accept model selection arguments.

Description

Avoid pulling TinyLlama from HF as it can hit HTTP error 429 (Too Many Requests for url)

Test Coverage

tests/integration/defs/examples/test_ray.py

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@achartier achartier requested a review from a team as a code owner October 24, 2025 20:55
@achartier
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

📝 Walkthrough

Walkthrough

The changes add CLI argument parsing for model selection to the Ray orchestrator example script and introduce a new orchestrator_type parameter to LLM initialization. The test is updated to provide the model path and corresponding flag when invoking the example script.

Changes

Cohort / File(s) Summary
Ray orchestrator example
examples/ray_orchestrator/llm_inference_async_ray.py, requirements.txt, pyproject.toml
Added argparse to parse --model CLI argument; wired model argument into LLM initialization; extended LLM constructor call to include orchestrator_type="ray" parameter; retained KV cache configuration with tensor parallelism option commented out
Ray example test
tests/integration/defs/examples/test_ray.py
Updated test_llm_inference_async_ray to supply model path via llm_models_root() (pointing to TinyLlama-1.1B-Chat-v1.0) and pass --model flag to script invocation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][chore] Use a cached model path for Ray integration test" is directly related to the main objective of the changeset, which is to avoid pulling the TinyLlama model from Hugging Face to prevent HTTP 429 errors. The title clearly describes the primary change—using a cached model path instead of downloading from HF—though it focuses more on the test aspect than mentioning the supporting script modifications that add --model argument handling. The title is concise, specific, and scannable, making it clear to a teammate reviewing the history what this change addresses.
Description Check ✅ Passed The PR description adequately follows the repository template structure with properly formatted sections. It includes a concise Description section explaining the issue (HTTP 429 errors from Hugging Face) and the rationale for the change, a Test Coverage section identifying the affected test file (tests/integration/defs/examples/test_ray.py), and a completed PR Checklist confirming review of coding guidelines, tests, and other relevant items. While the description is relatively brief, it covers all critical template sections and provides sufficient context about what the PR accomplishes and why.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02081e2 and 601d1ea.

📒 Files selected for processing (2)
  • examples/ray_orchestrator/llm_inference_async_ray.py (1 hunks)
  • tests/integration/defs/examples/test_ray.py (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/integration/defs/examples/test_ray.py
  • examples/ray_orchestrator/llm_inference_async_ray.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/integration/defs/examples/test_ray.py
  • examples/ray_orchestrator/llm_inference_async_ray.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/integration/defs/examples/test_ray.py
  • examples/ray_orchestrator/llm_inference_async_ray.py
🧬 Code graph analysis (2)
tests/integration/defs/examples/test_ray.py (3)
tests/unittest/_torch/executor/test_overlap_scheduler.py (1)
  • model_path (20-21)
tests/integration/defs/conftest.py (1)
  • llm_models_root (80-94)
tests/integration/defs/common.py (1)
  • venv_check_call (34-40)
examples/ray_orchestrator/llm_inference_async_ray.py (2)
tensorrt_llm/llmapi/llm.py (1)
  • LLM (1084-1100)
examples/ray_orchestrator/llm_inference_distributed_ray.py (1)
  • main (7-37)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/defs/examples/test_ray.py (1)

17-18: LGTM! Cached model path correctly prevents HuggingFace downloads.

The changes successfully address the PR objective by passing a cached model path to avoid HTTP 429 errors. The use of llm_models_root() ensures proper path resolution with fallback handling.

examples/ray_orchestrator/llm_inference_async_ray.py (2)

10-19: Verify the default model choice.

The argparse implementation is correct, but the default model still points to HuggingFace. When this script is run standalone without the --model argument, it will attempt to download from HuggingFace and could still encounter HTTP 429 errors.

Is this intentional to maintain standalone usability, or should the default also point to a cached path? If you'd like to fully prevent HuggingFace downloads, consider whether the default should be updated or if documentation should clarify that the --model flag is required in rate-limited environments.


27-27: LGTM! Model parameter correctly wired from CLI argument.

The change properly enables the script to accept a model path from the command line, allowing the test to pass in a cached path.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22471 [ run ] triggered by Bot. Commit: 601d1ea

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22471 [ run ] completed with state SUCCESS. Commit: 601d1ea
/LLM/main/L0_MergeRequest_PR pipeline #16936 completed with status: 'FAILURE'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants