Skip to content

Conversation

@dongfengy
Copy link
Collaborator

@dongfengy dongfengy commented Oct 25, 2025

… gptoss

Summary by CodeRabbit

  • Documentation
    • Added support for new devices to MoE Backend Support Matrix.
    • Restructured and clarified backend selection guidance with performance optimization focus.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@dongfengy dongfengy requested a review from a team as a code owner October 25, 2025 21:18
@dongfengy dongfengy requested review from QiJune and kaiyux October 25, 2025 21:18
@dongfengy dongfengy self-assigned this Oct 25, 2025
@dongfengy
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 25, 2025

📝 Walkthrough

Walkthrough

Updated documentation for TensorRT-LLM GPU-OSS deployment guide. The MoE Backend Support Matrix was revised to include additional GPU devices (B200/GB200/B300/GB300) and consolidate backend use cases into a unified column. Descriptive guidance about MOE backend selection was rephrased to emphasize performance optimization and added clarification about TRTLLM MOE throughput advantages.

Changes

Cohort / File(s) Summary
Documentation Updates
docs/source/deployment-guide/quick-start-recipe-for-gpt-oss-on-trtllm.md
Updated MoE Backend Support Matrix to include B200/GB200/B300/GB300 devices and merge use case entries. Revised MOE backend selection guidance to emphasize performance optimization and clarified TRTLLM MOE throughput benefits.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Review focus: Verify accuracy of GPU device listings in the support matrix and validate correctness of performance claims in the updated guidance text.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is largely incomplete. The repository template requires three key sections to be filled: Description (explaining the issue and solution), Test Coverage (listing relevant tests), and a completed PR Checklist. The provided description contains only a fragment ("… gptoss" and "@coderabbitai summary"), with both the Description and Test Coverage sections entirely empty and most checklist items unchecked. While this is a documentation-only change which may have minimal test requirements, the complete absence of a Description explaining what and why violates the template's fundamental expectations. The author should complete the Description section with a clear explanation of the documentation updates (e.g., explaining why the hardware support and performance guidance needed clarification), and address the Test Coverage section (noting that documentation changes may not require traditional testing, or specifying manual verification steps if applicable). Additionally, the author should review and check the appropriate PR Checklist items before merging to confirm compliance with repository standards.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][doc] Clarify the perf best practice and supported hardware for gptoss" directly aligns with the changeset, which updates MoE backend documentation to clarify performance best practices (emphasizing universal throughput optimization of TRTLLM MOE) and adds support for new hardware (B200/GB200/B300/GB300). The title follows the required template format with [None] for no ticket, [doc] for documentation type, and a clear, specific summary that accurately reflects the primary changes. The phrasing is concise, avoids vague terms, and would help teammates understand the main change when scanning history.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/source/deployment-guide/quick-start-recipe-for-gpt-oss-on-trtllm.md (1)

30-31: Improve clarity of backend guidance and soften absolutist language.

Line 31 uses informal phrasing ("was better... but now we have optimized") and states TRTLLM is "universally faster" as an absolute claim. For a documentation guide, consider rephrasing to be more precise about:

  • When TRTLLM should be used (e.g., "For low-latency workloads...")
  • Whether there are any remaining use cases where CUTLASS is preferred
  • The basis for the performance comparison

Consider revising lines 30-31 to:

-The default moe backend is `CUTLASS`, so for the best possible perf, one must set the `moe_config.backend` explicitly to run the model.
-`CUTLASS` was better for max throughput at first but now we have optimized `TRTLLM` moe to be universally faster.
+The default moe backend is `CUTLASS`. To achieve the best performance for your workload, explicitly set `moe_config.backend` based on your use case:
+- For low-latency inference: use TRTLLM (recommended for latency-sensitive applications)
+- For maximum throughput: [clarify whether TRTLLM or CUTLASS is recommended]
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a6d20f6 and ff7a29f.

📒 Files selected for processing (1)
  • docs/source/deployment-guide/quick-start-recipe-for-gpt-oss-on-trtllm.md (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22512 [ run ] triggered by Bot. Commit: ff7a29f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22512 [ run ] completed with state SUCCESS. Commit: ff7a29f
/LLM/main/L0_MergeRequest_PR pipeline #16969 completed with status: 'SUCCESS'

@dongfengy dongfengy force-pushed the user/dongfengy/ci_doc branch from 1958ce0 to 58d6cf1 Compare October 27, 2025 20:17
@dongfengy
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22678 [ run ] triggered by Bot. Commit: 58d6cf1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22678 [ run ] completed with state SUCCESS. Commit: 58d6cf1
/LLM/main/L0_MergeRequest_PR pipeline #17097 completed with status: 'SUCCESS'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants