[TRTLLM-8971][infra] Update gpu key for B300/GB300 #8724
Conversation
|
/bot run --stage-list "B300-PyTorch-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1" |
📝 WalkthroughWalkthroughThree test configuration YAML files are updated to add a new GPU wildcard pattern "b300" alongside the existing "gb110" pattern in their GPU wildcard lists. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml (1)
1-60: Consider documenting the scope of GPU pattern changes.The PR title and description lack detail about the B300/GB300 GPU pattern update. For future reference and to maintain clear change logs:
- Document why
*b300*patterns are being added alongside*gb110*patterns- Clarify the GPU model distinction (B300 vs. GB300) and how the patterns differentiate them
- Confirm whether all relevant test configuration files have been updated
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
tests/integration/test_lists/test-db/l0_dgx_b300.yml(1 hunks)tests/integration/test_lists/test-db/l0_gb300.yml(1 hunks)tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
📚 Learning: 2025-08-26T09:49:04.956Z
Learnt from: pengbowang-nv
PR: NVIDIA/TensorRT-LLM#7192
File: tests/integration/test_lists/test-db/l0_dgx_b200.yml:56-72
Timestamp: 2025-08-26T09:49:04.956Z
Learning: In TensorRT-LLM test configuration files, the test scheduling system handles wildcard matching with special rules that prevent duplicate test execution even when the same tests appear in multiple yaml files with overlapping GPU wildcards (e.g., "*b200*" and "*gb200*").
Applied to files:
tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/test_lists/test-db/l0_gb300.yml (1)
8-11: Verify the "b300" wildcard pattern approach.The change adds
*b300*to the GPU wildcard list alongside*gb110*. Before merging, confirm:
- Is
*b300*the correct pattern to match B300 GPUs (vs. GB300)?- Are there other test configuration files in the test-db directory that should also be updated?
Per the learnings from #7192, the test scheduling system handles overlapping GPU wildcards, so pattern overlap risk is mitigated.
tests/integration/test_lists/test-db/l0_dgx_b300.yml (1)
8-11: Pattern addition is consistent with l0_gb300.yml.The change mirrors the pattern update in
l0_gb300.yml, adding*b300*to GPU wildcards for the 4-GPU DGX configuration. Formatting and YAML syntax are correct.tests/integration/test_lists/test-db/l0_gb300_multi_gpus.yml (1)
8-11: Pattern addition is consistent across all three updated files.The change maintains consistency with updates in
l0_gb300.ymlandl0_dgx_b300.yml. All three files now include the*b300*pattern alongside*gb110*, covering single-GPU aarch64, 4-GPU x86_64, and 4-GPU aarch64 scenarios respectively.
|
PR_Github #22763 [ run ] triggered by Bot. Commit: |
|
PR_Github #22763 [ run ] completed with state |
Signed-off-by: qqiao <[email protected]>
Signed-off-by: qqiao <[email protected]>
EmmaQiaoCh
force-pushed
the
emma/fix_b300_test_stage
branch
from
64a8737 to
8919f68
Compare
|
/bot run --stage-list "B300-PyTorch-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #22838 [ run ] triggered by Bot. Commit: |
|
PR_Github #22838 [ run ] completed with state |
Signed-off-by: qqiao <[email protected]>
|
/bot run --stage-list "B300-PyTorch-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-1" |
|
PR_Github #22877 [ run ] triggered by Bot. Commit: |
|
PR_Github #22877 [ run ] completed with state |
|
/bot skip --comment "Tested locally and skip the CI" |
|
PR_Github #22968 [ skip ] triggered by Bot. Commit: |
|
PR_Github #22968 [ skip ] completed with state |
Signed-off-by: qqiao <[email protected]>
…8724) (#8796) Signed-off-by: qqiao <[email protected]>
3 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.