[None][infra] Add fallback when get wheel from build stage is fail #9290
Conversation
Signed-off-by: ZhanruiSunCh <[email protected]>
|
/bot run --stage-list "Build-Docker-Images" |
📝 WalkthroughWalkthroughRefactors wheel-building configuration by introducing a Changes
Sequence Diagram(s)sequenceDiagram
actor User
participant Build
participant WheelBuild as Wheel-Enabled Build
participant Retry as Retry Handler
participant MakeBuild as Make (without wheel)
User->>Build: Trigger build
Build->>Build: Prepare buildWheelArgs
alt buildWheelArgs present
Build->>WheelBuild: Execute with buildWheelArgs
rect rgb(200, 220, 255)
note right of WheelBuild: New: Try-catch block
WheelBuild->>WheelBuild: Build with wheel options
end
alt Exception occurs
rect rgb(255, 200, 200)
note right of Retry: New: Guarded retry
Retry->>MakeBuild: Retry without wheel args
MakeBuild->>MakeBuild: Build completes
end
else Success
WheelBuild->>Build: Build completes
end
else buildWheelArgs empty
Build->>Build: Standard build (unchanged)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
jenkins/BuildDockerImage.groovy (2)
381-393: Consider adding fallback logic to the custom tag build.The custom tag section includes
buildWheelArgs(line 390) but lacks the same try-catch fallback logic present in the main build (lines 349-375). If the custom tag build fails due to wheel-related issues, it won't retry without wheel arguments.Consider wrapping the custom tag build with similar fallback logic:
if (customTag) { stage ("custom tag: ${customTag} (${arch})") { try { sh """ cd ${LLM_ROOT} && make -C docker ${target}_${action} \ BASE_IMAGE=${BASE_IMAGE} \ TRITON_IMAGE=${TRITON_IMAGE} \ TORCH_INSTALL_TYPE=${torchInstallType} \ IMAGE_WITH_TAG=${customImageWithTag} \ STAGE=${dockerfileStage} \ BUILD_WHEEL_OPTS='-j ${build_jobs}' ${args} ${buildWheelArgs} """ } catch (InterruptedException ex) { throw ex } catch (Exception ex) { if (buildWheelArgs.trim().isEmpty()) { throw ex } echo "Build failed with wheel arguments, retrying custom tag without them" sh """ cd ${LLM_ROOT} && make -C docker ${target}_${action} \ BASE_IMAGE=${BASE_IMAGE} \ TRITON_IMAGE=${TRITON_IMAGE} \ TORCH_INSTALL_TYPE=${torchInstallType} \ IMAGE_WITH_TAG=${customImageWithTag} \ STAGE=${dockerfileStage} \ BUILD_WHEEL_OPTS='-j ${build_jobs}' ${args} """ } } }
366-374: Verify the nested retry strategy is intentional.The fallback build uses
numRetries: 2(line 374) while the initial build attempt usesnumRetries: 6(line 358). This creates nested retry logic where:
- Initial build with wheel args: up to 6 retries
- Fallback build without wheel args: up to 2 retries
This seems reasonable (fewer retries for fallback since wheel args are likely the issue), but please confirm this retry strategy aligns with your infrastructure resilience requirements.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
jenkins/BuildDockerImage.groovy(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/BuildDockerImage.groovy (1)
336-336: LGTM!Introducing the
buildWheelArgsvariable improves reusability and enables the fallback logic in the subsequent try-catch block.
|
PR_Github #24975 [ run ] triggered by Bot. Commit: |
Signed-off-by: ZhanruiSunCh <[email protected]>
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #24981 [ run ] triggered by Bot. Commit: |
|
PR_Github #24975 [ run ] completed with state |
|
PR_Github #24981 [ run ] completed with state |
| @@ -369,7 +387,7 @@ def buildImage(config, imageKeyToTag) | |||
| TORCH_INSTALL_TYPE=${torchInstallType} \ | |||
| IMAGE_WITH_TAG=${customImageWithTag} \ | |||
| STAGE=${dockerfileStage} \ | |||
| BUILD_WHEEL_OPTS='-j ${build_jobs}' ${args} | |||
| BUILD_WHEEL_OPTS='-j ${build_jobs}' ${args} ${buildWheelArgs} | |||
There was a problem hiding this comment.
@ZhanruiSunCh I think whether ${buildWheelArgs} is added here also depending on whether the fallback path is called. Otherwise, it would lead to inconsistency.
There was a problem hiding this comment.
Done. I add buildWheelArgs="" when the fallback path is called.
Signed-off-by: ZhanruiSunCh <[email protected]>
Signed-off-by: ZhanruiSunCh <[email protected]>
|
/bot run --stage-list "Build-Docker-Images" |
|
PR_Github #25153 [ run ] triggered by Bot. Commit: |
|
PR_Github #25153 [ run ] completed with state |
4 participants
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.