Skip to content

Conversation

@mlefeb01
Copy link
Collaborator

@mlefeb01 mlefeb01 commented Nov 19, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Updated SSH configuration to properly use the cluster's configured SSH port for remote operations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@mlefeb01 mlefeb01 self-assigned this Nov 19, 2025
@mlefeb01 mlefeb01 requested review from a team as code owners November 19, 2025 19:13
@mlefeb01
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

📝 Walkthrough

Walkthrough

Adds a port field set to cluster.sshPort in SSH remote configurations across multiple functions, enabling cluster-specific SSH port usage for remote operations including file uploads, Slurm resource cleanup, and test execution commands.

Changes

Cohort / File(s) Summary
SSH Port Configuration
jenkins/L0_Test.groovy
Introduces port: cluster.sshPort field in remote SSH configuration maps across functions: uploadResults, cleanUpSlurmResources, cleanUpNodeResources, runLLMTestlistWithAgent, runLLMTestlistWithSbatch, and related code paths

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10–15 minutes

  • Verify all SSH-based remote operations consistently include the new port field
  • Confirm cluster.sshPort is available and properly defined in all contexts where it's accessed
  • Check for any legacy SSH connections or edge cases that may have been unintentionally omitted

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely filled with template boilerplate and placeholders; it lacks any concrete explanation of the issue, solution, test coverage, or checklist completion details. Replace template placeholders with actual descriptions: explain the issue and solution, list relevant tests, and provide genuine checklist responses addressing the specific changes in this PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and specifically describes the main change: consuming SlurmCluster sshPort for clusters with custom SSH port, which aligns with the code changes introducing port field in SSH configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1eae941 and e43c362.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (5)
jenkins/L0_Test.groovy (5)

398-453: LGTM! Port configuration properly added.

The addition of port: cluster.sshPort at line 404 correctly enables custom SSH port support for Slurm resource cleanup. This function uses Utils.sshUserCmd() helper which should handle the port internally from the remote map.


456-503: LGTM! Port configuration properly added.

The custom SSH port is correctly configured at line 462 for node resource cleanup operations.


591-612: LGTM! Port configuration properly added.

The custom SSH port is correctly configured at line 597 for checking node online status.


113-117: Verify cluster.sshPort field availability in external SlurmCluster dependency.

The SlurmCluster class is imported from the external library com.nvidia.bloom.SlurmCluster (line 11), and its definition is not available in this repository. The code assumes the sshPort field exists and is properly initialized across six locations (lines 117, 404, 462, 528, 597, 820).

Ensure that:

  1. The external com.nvidia.bloom.SlurmCluster class defines the sshPort field
  2. A sensible default (port 22) is provided when not explicitly configured
  3. The field contains a valid port number (1-65535)

807-1044: Verify that Utils.copyFileToRemoteHost uses the custom SSH port from the remote configuration.

The port field is correctly added to the remote map at line 820. However, Utils.copyFileToRemoteHost is from the external package com.nvidia.bloom.Utils, which is not available in this repository to verify. The implementation cannot be confirmed within the codebase.

Additionally, other direct SSH commands in the same file (e.g., lines 130, 542) do not use the port field from the remote map—they omit the -P flag and rely on the default SSH port. This pattern suggests the custom port handling may not be consistently implemented.

Confirm that the external Utils.copyFileToRemoteHost function properly uses the port field when establishing SSH connections to remote hosts.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25083 [ run ] triggered by Bot. Commit: e43c362

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25083 [ run ] completed with state SUCCESS. Commit: e43c362
/LLM/main/L0_MergeRequest_PR pipeline #18961 completed with status: 'FAILURE'

@mlefeb01
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25102 [ run ] triggered by Bot. Commit: e43c362

Signed-off-by: Matt Lefebvre <[email protected]>
Signed-off-by: Matt Lefebvre <[email protected]>
Signed-off-by: Matt Lefebvre <[email protected]>
@mlefeb01
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25124 [ run ] triggered by Bot. Commit: 58656e1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25102 [ run ] completed with state ABORTED. Commit: e43c362
LLM/main/L0_MergeRequest_PR #18977 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25124 [ run ] completed with state SUCCESS. Commit: 58656e1
/LLM/main/L0_MergeRequest_PR pipeline #18992 completed with status: 'FAILURE'

@mlefeb01
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25233 [ run ] triggered by Bot. Commit: ae75ff6

@mlefeb01
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25254 [ run ] triggered by Bot. Commit: cec7d60

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25233 [ run ] completed with state ABORTED. Commit: ae75ff6
LLM/main/L0_MergeRequest_PR #19084 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25254 [ run ] completed with state SUCCESS. Commit: cec7d60
/LLM/main/L0_MergeRequest_PR pipeline #19102 completed with status: 'FAILURE'

@mlefeb01
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25375 [ run ] triggered by Bot. Commit: cec7d60

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25375 [ run ] completed with state ABORTED. Commit: cec7d60
LLM/main/L0_MergeRequest_PR #19193 (Blue Ocean) completed with status: ABORTED

@yuanjingx87
Copy link
Collaborator

/bot skip --comment "existing passing tests are sufficient"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25400 [ skip ] triggered by Bot. Commit: cec7d60

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25400 [ skip ] completed with state SUCCESS. Commit: cec7d60
Skipping testing for commit cec7d60

@mlefeb01 mlefeb01 merged commit fefa02f into NVIDIA:main Nov 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants