[None][chore] Reduce nested nvtx ranges. #9347
Conversation
Signed-off-by: Yuxian Qiu <[email protected]>
|
/bot run --disable-fail-fast |
📝 WalkthroughWalkthroughThese changes refactor the distributed pipeline-parallel communication layer by replacing the PPComm class with PPCommNCCL, removing PPComm from the public API, reordering synchronization in request broadcasting, and standardizing NVTX profiling instrumentation with context managers instead of manual push/pop calls. Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant init_pp_comm
participant PPCommNCCL
Caller->>init_pp_comm: init_pp_comm(mapping)
alt MPI enabled
init_pp_comm->>PPCommNCCL: create PPCommNCCL(mapping)
PPCommNCCL-->>init_pp_comm: instance
else MPI not enabled
init_pp_comm-->>Caller: None
end
init_pp_comm-->>Caller: _pp_comm = PPCommNCCL instance
sequenceDiagram
participant Code
participant send_requests_handler
participant send_to_next_pp
Note over Code: Old flow
Code->>send_to_next_pp: enter send block
send_to_next_pp->>send_requests_handler: wait() inside send
send_requests_handler-->>send_to_next_pp: ready
send_to_next_pp->>send_to_next_pp: isend_object()
Note over Code: New flow
Code->>send_requests_handler: wait() before send block
send_requests_handler-->>Code: ready
Code->>send_to_next_pp: enter send block
send_to_next_pp->>send_to_next_pp: isend_object()
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
🧰 Additional context used🧠 Learnings (9)📓 Common learnings📚 Learning: 2025-09-23T15:12:38.312ZApplied to files:
📚 Learning: 2025-09-24T03:31:28.908ZApplied to files:
📚 Learning: 2025-09-02T13:42:44.885ZApplied to files:
📚 Learning: 2025-09-16T09:30:09.716ZApplied to files:
📚 Learning: 2025-09-23T15:12:38.312ZApplied to files:
📚 Learning: 2025-08-14T06:36:40.701ZApplied to files:
📚 Learning: 2025-08-19T12:45:11.997ZApplied to files:
📚 Learning: 2025-09-23T14:58:05.372ZApplied to files:
🧬 Code graph analysis (3)tensorrt_llm/_torch/distributed/__init__.py (1)
tensorrt_llm/_torch/pyexecutor/executor_request_queue.py (2)
tensorrt_llm/_torch/pyexecutor/py_executor.py (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (6)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
PR_Github #25272 [ run ] triggered by Bot. Commit: |
|
PR_Github #25272 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #25313 [ run ] triggered by Bot. Commit: |
|
PR_Github #25313 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #25473 [ run ] triggered by Bot. Commit: |
|
PR_Github #25473 [ run ] completed with state |
4 participants
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.