Skip to content

Added exception for warning caused while creating int4 tensor #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2025
Merged

Added exception for warning caused while creating int4 tensor #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
247e4c7
Added exception for warning caused while creating int4 tensor
hthadicherla Oct 24, 2025
948478c
Merge branch 'main' into hthadicherla/int4-warning-fix
hthadicherla Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modelopt/onnx/quantization/gs_patching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,14 @@ def _make_constant(
converted_dtype = (
dtype if isinstance(values, LazyValues) else onnx.helper.tensor_dtype_to_np_dtype(dtype)
)
if values.dtype != converted_dtype:

# Allow int8/uint8 as intermediate representation for INT4/UINT4
# INT4/UINT4 values are stored as int8/uint8 in numpy arrays and packed during export
is_valid_int4_intermediate = (dtype == onnx.TensorProto.INT4 and values.dtype == np.int8) or (
dtype == onnx.TensorProto.UINT4 and values.dtype == np.uint8
)

if not is_valid_int4_intermediate and values.dtype != converted_dtype:
logger.error(
f"Trying to create tensor with incompatible types: `{values.dtype}`, `{dtype}`"
)
Expand Down