Skip to content

Conversation

@danielkorzekwa
Copy link

What does this PR do?

Type of change: ?
new feature

Overview: ?
E2E test for the experimental compress algorithm based on https://arxiv.org/abs/2411.19146

Usage

See tests/gpu/torch/_compress/test_compress.py

# Add a code snippet demonstrating how to use this

See tests/gpu/torch/_compress/test_compress.py

Testing

See tests/gpu/torch/_compress/test_compress.py

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes
  • Did you write any new necessary tests?: Yes
  • Did you add or update any necessary documentation?: No
  • Did you update Changelog?: No

Additional Information

using MIP-based NAS search algorithm.

Signed-off-by: Daniel Korzekwa <[email protected]>
Signed-off-by: Daniel Korzekwa <[email protected]>
Signed-off-by: Daniel Korzekwa <[email protected]>
@danielkorzekwa danielkorzekwa requested a review from a team as a code owner October 27, 2025 11:33
@danielkorzekwa danielkorzekwa requested review from ChenhanYu and Edwardf0t1 and removed request for a team October 27, 2025 11:33
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kevalmorabia97 kevalmorabia97 requested review from AAnoosheh and kevalmorabia97 and removed request for Edwardf0t1 October 27, 2025 11:36
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.40%. Comparing base (230cee1) to head (d942e0a).
⚠️ Report is 2 commits behind head on feature/compress.

Additional details and impacted files
@@                Coverage Diff                @@
##           feature/compress     #464   +/-   ##
=================================================
  Coverage             73.40%   73.40%           
=================================================
  Files                   180      180           
  Lines                 18077    18077           
=================================================
  Hits                  13270    13270           
  Misses                 4807     4807           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the resources/tokenizer used as a toy tokenizer for testing instead of using original llama tokenizer?

We can instead re-use test toy models and tokenizers used in other tests. See comment below in gpu test file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created an internal issue to address this in the next MR: issues/12

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR, but do we also plan to simplify the yaml files as part of roadmap? Currently there are too many things to be configured and in too many yaml files, which we can move to one common base yaml hidden from users and only require user to provide 4-5 most important inputs to keep things simpler

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is captured in the Nvidia internal roadmap

@danielkorzekwa danielkorzekwa requested a review from a team as a code owner October 27, 2025 14:35
Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Thanks for addressing my comments

@kevalmorabia97 kevalmorabia97 merged commit 9eeee25 into feature/compress Oct 28, 2025
26 checks passed
@kevalmorabia97 kevalmorabia97 deleted the dkorzekwa/e2e_compression_test branch October 28, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants