Skip to content

Conversation

@nvluxiaoz
Copy link

What does this PR do?

Type of change: Bug fix

Overview: While attempting to transformers, onnx, torch and modelopt, it is shown the following:

  • Original Reshape - Cast - Transpose becomes Reshape - Transpose, so there is no required Cast for int4
  • Global cast replacement to FP16 is not required since it will affect other Modules

Usage

# Add a code snippet demonstrating how to use this

Testing

Before your PR is "Ready for review"

  • Make sure you read and follow Contributor guidelines and your commits are signed.
  • Is this change backward compatible?: Yes
  • Did you write any new necessary tests?: No
  • Did you add or update any necessary documentation?: No
  • Did you update Changelog?: No

Additional Information

@nvluxiaoz nvluxiaoz requested a review from a team as a code owner October 31, 2025 07:37
@nvluxiaoz nvluxiaoz requested a review from i-riyad October 31, 2025 07:37
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 31, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nvluxiaoz nvluxiaoz force-pushed the dev-luxiaoz-fix-onnx-export branch 3 times, most recently from 55805b3 to 639a0f3 Compare November 1, 2025 00:10
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.31%. Comparing base (ed58324) to head (a51b00d).

Files with missing lines Patch % Lines
modelopt/onnx/quantization/qdq_utils.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   73.46%   74.31%   +0.84%     
==========================================
  Files         180      180              
  Lines       18141    18129      -12     
==========================================
+ Hits        13328    13473     +145     
+ Misses       4813     4656     -157     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nvluxiaoz nvluxiaoz force-pushed the dev-luxiaoz-fix-onnx-export branch from 639a0f3 to a51b00d Compare November 4, 2025 22:12
@nvluxiaoz
Copy link
Author

@ajrasane Do you know if this pipeline is counted as successful, and if not, what fails? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants