[NVBUG: 5617733] Update LLM generate API for modelopt LLM eval #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chenjie Luo <[email protected]>
cjluo-nv
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 180 180
Lines 18149 18149
=======================================
Hits 13328 13328
Misses 4821 4821 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…o chenjiel/update_generate
meenchen
approved these changes
Nov 4, 2025
kevalmorabia97
pushed a commit
that referenced
this pull request
Nov 4, 2025
## What does this PR do? **Type of change:** ? Bug fix **Overview:** ? 1) Remove kv_cache_config in the generate API. It's no longer used in the code as well. We just estimate KV cache usage from other parameters 2) Add max_seq_len in the generate API to better estimate the real KV cache usage. 3) Assume default lm_eval max input sequence length to be 4096 Signed-off-by: Chenjie Luo <[email protected]>
mxinO
pushed a commit
that referenced
this pull request
Nov 11, 2025
## What does this PR do? **Type of change:** ? Bug fix **Overview:** ? 1) Remove kv_cache_config in the generate API. It's no longer used in the code as well. We just estimate KV cache usage from other parameters 2) Add max_seq_len in the generate API to better estimate the real KV cache usage. 3) Assume default lm_eval max input sequence length to be 4096 Signed-off-by: Chenjie Luo <[email protected]> Signed-off-by: mxin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: ? Bug fix
Overview: ?