[libcu++] harden the preprocessor machinery to avoid user defined tokens#9407
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c95d9b5b-46e9-43df-ba00-8bcff57dc9de
📒 Files selected for processing (2)
libcudacxx/include/cuda/std/__cccl/preprocessor.hlibcudacxx/include/cuda/std/__concepts/concept_macros.h
fbusato
approved these changes
Jun 11, 2026
davebayer
requested changes
Jun 11, 2026
davebayer
left a comment
davebayer
left a comment
Contributor
There was a problem hiding this comment.
Let's prefix everything that is not an immediate macro parameter with _CCCL to prevent this happening again because of some _-prefixed macros
This comment has been minimized.
This comment has been minimized.
miscco
force-pushed
the
harden_preprocessor
branch
from
fb55dc9 to
bb1f8d4
Compare
davebayer
approved these changes
Jun 12, 2026
Contributor
Author
|
/ok to test |
miscco
force-pushed
the
harden_preprocessor
branch
from
bb1f8d4 to
62fdd29
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4c47dd11-ad15-4a65-8af0-f18f4c3d4080
📒 Files selected for processing (2)
libcudacxx/include/cuda/std/__cccl/preprocessor.hlibcudacxx/include/cuda/std/__concepts/concept_macros.h
🚧 Files skipped from review as they are similar to previous changes (1)
- libcudacxx/include/cuda/std/__cccl/preprocessor.h
miscco
force-pushed
the
harden_preprocessor
branch
from
62fdd29 to
74b76ac
Compare
Contributor
Author
|
@CodeRabbit full review |
Contributor
✅ Action performedFull review finished. |
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 26m: Pass: 100%/118 | Total: 6d 09h | Max: 4h 26m | Hits: 35%/3202046See results here. |
Contributor
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should not use non reserved identifiers.
Fixes #9406