Optimize Metropolis2D IoU evaluation - #313
Open
raus7n wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the Metropolis2D 2D detection evaluation by precomputing the prediction-to-ground-truth IoU matrix once per image and reusing it across all IoU thresholds.
Motivation
The evaluator uses 10 IoU thresholds from 0.50 to 0.95. Previously, the same prediction/ground-truth IoU pairs were recomputed independently for each threshold.
For
Npredictions,Mground-truth boxes, andTIoU thresholds, this results in approximately:O(T × N × M)IoU calculations.
Changes
N × MIoU matrix once for each image.This reduces the number of IoU calculations from approximately:
O(T × N × M)to:
O(N × M)where
T = 10.Validation
python -m py_compile evaluation/cosmos3/reasoner/vlmevalkit/vlmeval/dataset/metropolis2d/detection_2d_dataset.pygit diff --checkTesting
The existing evaluation logic and matching semantics are unchanged. The optimized implementation was syntax-checked successfully.