Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure cuda is a namespace package #493

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Ensure cuda is a namespace package #493

wants to merge 2 commits into from

Conversation

leofang
Copy link
Member

@leofang leofang commented Mar 6, 2025 •
edited
Loading

Close #477.

@leofang leofang added this to the cuda-python 12-next, 11-next milestone Mar 6, 2025
@leofang leofang self-assigned this Mar 6, 2025
@copy-pr-bot copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Mar 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member Author

leofang commented Mar 6, 2025

/ok to test

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-493/

https://nvidia.github.io/cuda-python/pr-preview/pr-493/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-493/cuda-bindings/


Preview will be ready when the GitHub Pages deployment is complete.

@leofang leofang added bug Something isn't working enhancement Any code-related improvements P0 High priority - Must do! cuda.bindings Everything related to the cuda.bindings module labels Mar 6, 2025
rwgk
rwgk approved these changes Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This certainly looks great to me!

I'm wondering though, what exactly was the reason for adding these files? How much trouble is it to leave some hints in the PR description?

@leofang leofang mentioned this pull request Mar 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

Assignees

@leofang leofang

Labels
bug Something isn't working cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P0 High priority - Must do!
Projects
None yet
Milestone
cuda-python 12.9.0 & 11.8.7
Development

Successfully merging this pull request may close these issues.

Remove cuda/__init__.py to avoid confusing various tools
2 participants
@leofang @rwgk