Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Operators and Integration with cudensitymat #2407

Closed
wants to merge 248 commits into from

Conversation

sacpis
Copy link
Collaborator

@sacpis sacpis commented Nov 25, 2024

Adding missing operations in operators

Co-authored with @anthony-santana.

@sacpis sacpis requested review from bettinaheim and 1tnguyen and removed request for bettinaheim and 1tnguyen November 25, 2024 04:48
@@ -0,0 +1,495 @@
/*******************************************************************************
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited for this feature. I appreciate all the work you two have done on this one. One thought here -

Operators are more broad that dynamics. Ideally this would be part of a cudaq/operators.h public header. Did we ever finish the language review for this feature? Would be good to get a meeting scheduled.

Copy link

copy-pr-bot bot commented Dec 3, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 0f6496d to 791fb25 Compare December 19, 2024 19:50
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 2c1f0a2 to 92c922f Compare January 8, 2025 22:27
@sacpis sacpis closed this Jan 9, 2025
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 92c922f to da44eda Compare January 9, 2025 17:23
@sacpis sacpis temporarily deployed to ghcr-deployment January 9, 2025 17:24 — with GitHub Actions Inactive
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@sacpis sacpis temporarily deployed to ghcr-deployment January 9, 2025 17:24 — with GitHub Actions Inactive
Copy link

github-actions bot commented Jan 9, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:08 — with GitHub Actions Inactive
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:09 — with GitHub Actions Inactive
@sacpis sacpis temporarily deployed to backend-validation January 10, 2025 03:09 — with GitHub Actions Inactive
sacpis and others added 13 commits February 10, 2025 08:08
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
* Adding mock function to create a matrix operator
* Adding unittests for mul
* Formatting

Signed-off-by: Sachin Pisal <[email protected]>
* Adding function to get space_mode_extents
* Adding more unittests for op_conversion

Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
@sacpis sacpis force-pushed the dynamics_cpp_operators branch from 2cb8adb to f9dccab Compare February 11, 2025 04:36
@1tnguyen 1tnguyen force-pushed the dynamics_cpp_operators branch from f9dccab to 2cb8adb Compare February 11, 2025 05:14
sacpis and others added 13 commits February 10, 2025 21:16
Signed-off-by: Thien Nguyen <[email protected]>
* Correcting tensor callback function name

Signed-off-by: Sachin Pisal <[email protected]>
* Moved other reponsibilities like flattening the matrix, gettting
  subspace extents to the create elementary operator function
* Unittests updated
* Wrapped cudm_helper in a class

Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
github-actions bot pushed a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants