Add angle-producing math functions to kernels with docs and tests by LakshikkaNathan · Pull Request #4697 · NVIDIA/cuda-quantum

LakshikkaNathan · 2026-06-08T15:15:06Z

Summary

Completes the continuous, angle-producing math functions from the acceptance plan in #2942 (sin, cos, tan, asin, acos, atan, sqrt, exp, log) for C++ and Python: it adds the functions that were not yet supported, and documents and tests the full set.

C++ (lib/Frontend/nvqpp/ConvertExpr.cpp): lowering for std::asin, std::acos, std::atan. The other angle functions were already supported.
Python (python/cudaq/kernel/ast_bridge.py): adds np.tan, np.asin, np.acos, np.atan, np.log to the supported NumPy functions and lowers them to the matching math dialect ops (real-valued; complex inputs raise).

Against the acceptance plan

C++ supported functions documented in the kernel specification (docs/sphinx/specification/cudaq/kernels.rst).
Python supported functions documented in the same place.
Per-function simulator value tests for all nine functions (test_kernel_float.py), plus a FileCheck lowering test (test/AST-Quake/math_functions.cpp) covering double and float.
An executed gate-parameter test: ry(2*asin(sqrt(p))) prepares a state with P(|1>) = p, verified by sampling.
Continuous angle functions kept separate from discrete control functions.

Testing

Built from source in the cuda-quantum-dev container. The new tests pass, the existing test_kernel_float.py suite still passes, and the FileCheck test passes via cudaq-quake | cudaq-opt | FileCheck.

Note

I'm aware of #4680, which addresses the same issue. This PR takes a similar core approach and additionally includes the documentation and the executed gate-parameter test from the acceptance plan.

AI usage

I used Claude as a coding assistant to help draft this change. I built CUDA-Q from source, ran and verified the tests, and reviewed the full patch before submitting.

Adds C++ lowering for std::asin/acos/atan and Python lowering for np.tan/asin/acos/atan/log, documents the supported functions for both languages in the kernel spec, and adds per-function simulator tests plus a gate-parameter test. Addresses NVIDIA#2942. Signed-off-by: Lakshikka Sithamparanathan <2922185@vikes.csuohio.edu>

copy-pr-bot · 2026-06-08T15:15:11Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

# Conflicts: # cudaq/test/AST-Quake/math_functions.cpp

sacpis · 2026-06-08T17:17:50Z

/ok to test 43a36fb

Command Bot: Processing...

github-actions · 2026-06-08T17:22:25Z

CI Summary (`push`) — ✅ passed

Run #27425223681 · ✅ 6 · ⏩ 7 · ❌ 0 · ⛔ 0

Top-level jobs (13)

Job	Result
`binaries`	⏩ skipped
`build_and_test`	✅ success
`config_devdeps`	✅ success
`config_source_build`	⏩ skipped
`config_wheeldeps`	✅ success
`devdeps`	✅ success
`docker_image`	⏩ skipped
`gen_code_coverage`	⏩ skipped
`metadata`	✅ success
`python_metapackages`	⏩ skipped
`python_wheels`	⏩ skipped
`source_build`	⏩ skipped
`wheeldeps`	✅ success

⏩ Skipped jobs (7) — intentionally skipped on PR builds; run on merge_group / workflow_dispatch

Job
`binaries`
`config_source_build`
`docker_image`
`gen_code_coverage`
`python_metapackages`
`python_wheels`
`source_build`

All sub-jobs (42) — every matrix leg, with links

Job	Status	Link
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
CI Summary	❔ in_progress	view
Configure build (devdeps)	✅ success	view
Configure build (source_build)	⏩ skipped	view
Configure build (wheeldeps)	✅ success	view
Create CUDA Quantum installer	⏩ skipped	view
Create Docker images	⏩ skipped	view
Create Python metapackages	⏩ skipped	view
Create Python wheels	⏩ skipped	view
Gen code coverage	⏩ skipped	view
Load dependencies (amd64, gcc12) / Caching	✅ success	view
Load dependencies (amd64, gcc12) / Finalize	✅ success	view
Load dependencies (amd64, gcc12) / Metadata	✅ success	view
Load dependencies (amd64, llvm) / Caching	✅ success	view
Load dependencies (amd64, llvm) / Finalize	✅ success	view
Load dependencies (amd64, llvm) / Metadata	✅ success	view
Load dependencies (arm64, gcc12) / Caching	✅ success	view
Load dependencies (arm64, gcc12) / Finalize	✅ success	view
Load dependencies (arm64, gcc12) / Metadata	✅ success	view
Load dependencies (arm64, llvm) / Caching	✅ success	view
Load dependencies (arm64, llvm) / Finalize	✅ success	view
Load dependencies (arm64, llvm) / Metadata	✅ success	view
Load source build cache	⏩ skipped	view
Load wheel dependencies (amd64, 12.6) / Caching	✅ success	view
Load wheel dependencies (amd64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (amd64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (amd64, 13.0) / Caching	✅ success	view
Load wheel dependencies (amd64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (amd64, 13.0) / Metadata	✅ success	view
Load wheel dependencies (arm64, 12.6) / Caching	✅ success	view
Load wheel dependencies (arm64, 12.6) / Finalize	✅ success	view
Load wheel dependencies (arm64, 12.6) / Metadata	✅ success	view
Load wheel dependencies (arm64, 13.0) / Caching	✅ success	view
Load wheel dependencies (arm64, 13.0) / Finalize	✅ success	view
Load wheel dependencies (arm64, 13.0) / Metadata	✅ success	view
Prepare cache clean-up	❔ in_progress	view
Retrieve PR info	✅ success	view

✅ Required checks (6/6) — declared in .github/required-checks.yml for push

Required check	Status	Link
Build and test (amd64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (arm64, llvm, openmpi) / Dev environment (Python)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Debug)	✅ success	view
Build and test (amd64, gcc12, openmpi) / Dev environment (Python)	✅ success	view

Signed-off-by: Lakshikka Sithamparanathan <2922185@vikes.csuohio.edu>

LakshikkaNathan · 2026-06-08T18:18:07Z

Thanks @sacpis. Pushed a yapf formatting fix in the latest commit (3ffd148). Could you re-run on the latest commit when you get a chance? Thanks

sacpis · 2026-06-08T20:19:05Z

/ok to test 845b40b

Command Bot: Processing...

sacpis

Overall LGTM. Thanks @LakshikkaNathan. Left a few comments. Once we have those changes, will take a look at it again before approving.

Signed-off-by: Lakshikka Sithamparanathan <2922185@vikes.csuohio.edu>

LakshikkaNathan · 2026-06-09T13:40:39Z

Thanks for the review, @sacpis! Addressed all the comments in 41c15fd5, added arcsin/arccos/arctan support in ast_bridge.py and switched the test kernels to match. Ready for another look whenever you have time.

sacpis · 2026-06-10T16:57:30Z

/ok to test a53ca21

Command Bot: Processing...

Signed-off-by: Lakshikka Sithamparanathan <2922185@vikes.csuohio.edu>

LakshikkaNathan · 2026-06-10T19:41:09Z

Added the np.float32 tests in 84e441c. Ready for another look, thanks @sacpis!

sacpis · 2026-06-10T20:56:08Z

/ok to test 84e441c

Command Bot: Processing...

LakshikkaNathan · 2026-06-11T11:49:38Z

Thanks for running the tests. The failing test_quantinuum_observe doesn't appear to be related to this PR's changes, since its ansatz uses only x, ry, and x.ctrl, none of the math functions added here. The tests added in this PR pass. Could you let me know if this is a known failure on main? Happy to rebase once it's resolved.

sacpis · 2026-06-11T16:56:09Z

/ok to test 4ecc8bd

Command Bot: Processing...

sacpis · 2026-06-12T15:23:01Z

/ok to test ca74a0f

Command Bot: Processing...

Merge remote-tracking branch 'upstream/main' into math-functions-2942

43a36fb

# Conflicts: # cudaq/test/AST-Quake/math_functions.cpp

Apply yapf formatting to ast_bridge.py

3ffd148

Signed-off-by: Lakshikka Sithamparanathan <2922185@vikes.csuohio.edu>

Merge branch 'main' into math-functions-2942

845b40b

sacpis reviewed Jun 8, 2026

View reviewed changes

Comment thread cudaq/lib/Frontend/nvqpp/ConvertExpr.cpp

Comment thread python/tests/kernel/test_kernel_float.py Outdated

Comment thread python/tests/kernel/test_kernel_float.py Outdated

Comment thread python/tests/kernel/test_kernel_float.py Outdated

Add NumPy arcsin/arccos/arctan support to Python kernel frontend

41c15fd

Signed-off-by: Lakshikka Sithamparanathan <2922185@vikes.csuohio.edu>

Merge branch 'main' into math-functions-2942

a53ca21

sacpis reviewed Jun 10, 2026

View reviewed changes

Comment thread python/tests/kernel/test_kernel_float.py Outdated

Add np.float32 math function tests and rename float64 test

84e441c

Signed-off-by: Lakshikka Sithamparanathan <2922185@vikes.csuohio.edu>

Merge branch 'main' into math-functions-2942

4ecc8bd

Merge branch 'main' into math-functions-2942

ca74a0f

kish-00 mentioned this pull request Jun 17, 2026

feat: add tan, log, floor, asin, acos, atan math functions to kernel expressions #4747

Closed

Conversation

LakshikkaNathan commented Jun 8, 2026

Summary

Against the acceptance plan

Testing

Note

AI usage

Uh oh!

copy-pr-bot Bot commented Jun 8, 2026

Uh oh!

sacpis commented Jun 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Summary (push) — ✅ passed

Uh oh!

LakshikkaNathan commented Jun 8, 2026

Uh oh!

sacpis commented Jun 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sacpis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LakshikkaNathan commented Jun 9, 2026

Uh oh!

sacpis commented Jun 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

LakshikkaNathan commented Jun 10, 2026

Uh oh!

sacpis commented Jun 10, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LakshikkaNathan commented Jun 11, 2026

Uh oh!

sacpis commented Jun 11, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sacpis commented Jun 12, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sacpis commented Jun 8, 2026 •

edited by github-actions Bot

Loading

github-actions Bot commented Jun 8, 2026 •

edited

Loading

CI Summary (`push`) — ✅ passed

sacpis commented Jun 8, 2026 •

edited by github-actions Bot

Loading

sacpis commented Jun 10, 2026 •

edited by github-actions Bot

Loading

sacpis commented Jun 10, 2026 •

edited by github-actions Bot

Loading

sacpis commented Jun 11, 2026 •

edited by github-actions Bot

Loading

sacpis commented Jun 12, 2026 •

edited by github-actions Bot

Loading