Fix check-targets runtime library deps#4738
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nanook Claw <nanook@agentmail.to>
Collaborator
Collaborator
|
Thanks for the contribution! I don't have the context to know what the expected behaviour of cmake should be here. @schweitzpgi can you check if this does what you want? @nanookclaw just to confirm: this is not a unitary hack contribution, correct? If it is, you need to mark it as such today and we'd have to merge it in quickly. Otherwise let's resolve this next week. |
Author
|
Correct, this is not a Unitary Hack contribution. No urgency from that program on my side; resolving it next week is fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1571.
check-targetsalready depends on the globalCUDAQ_RUNTIME_LIBSlist, but a few runtime/plugin libraries used by target tests are not registered there. This adds an explicit guarded dependency list for the current targets that match the maintainer-provided missing-library list:cudaq-chemistrycudaq-platform-mqpucudaq-py-utilscudaq-rest-qpuThe entries are wrapped in
if(TARGET ...)so optional REST/Python/runtime plugin targets only becomecheck-targetsdependencies when that build actually defines them.I did not add entries for
cudaq-simulator-qpuorrest-remote-platform-clientbecause I could not find current CMake targets or references with those names at HEAD; they appear to have been renamed or removed since the issue comment was written.Testing
git diff --checkI did not run a full CUDA-Q build locally; this host does not have the project toolchain/CUDA build environment set up.