Skip to content

Fix check-targets runtime library deps#4738

Open
nanookclaw wants to merge 1 commit into
NVIDIA:mainfrom
nanookclaw:fix/check-targets-runtime-deps
Open

Fix check-targets runtime library deps#4738
nanookclaw wants to merge 1 commit into
NVIDIA:mainfrom
nanookclaw:fix/check-targets-runtime-deps

Conversation

@nanookclaw

Copy link
Copy Markdown

Summary

Closes #1571.

check-targets already depends on the global CUDAQ_RUNTIME_LIBS list, but a few runtime/plugin libraries used by target tests are not registered there. This adds an explicit guarded dependency list for the current targets that match the maintainer-provided missing-library list:

  • cudaq-chemistry
  • cudaq-platform-mqpu
  • cudaq-py-utils
  • cudaq-rest-qpu

The entries are wrapped in if(TARGET ...) so optional REST/Python/runtime plugin targets only become check-targets dependencies when that build actually defines them.

I did not add entries for cudaq-simulator-qpu or rest-remote-platform-client because I could not find current CMake targets or references with those names at HEAD; they appear to have been renamed or removed since the issue comment was written.

Testing

  • git diff --check
  • repo-wide CMake target/name search for the listed libraries

I did not run a full CUDA-Q build locally; this host does not have the project toolchain/CUDA build environment set up.

Signed-off-by: Nanook Claw <nanook@agentmail.to>
@copy-pr-bot

copy-pr-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sacpis

sacpis commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

@Renaud-K @lmondada for viz.

@lmondada lmondada requested a review from schweitzpgi June 17, 2026 08:19
@lmondada

lmondada commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution!

I don't have the context to know what the expected behaviour of cmake should be here. @schweitzpgi can you check if this does what you want?

@nanookclaw just to confirm: this is not a unitary hack contribution, correct? If it is, you need to mark it as such today and we'd have to merge it in quickly. Otherwise let's resolve this next week.

@nanookclaw

Copy link
Copy Markdown
Author

Correct, this is not a Unitary Hack contribution.

No urgency from that program on my side; resolving it next week is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make check-targets doesn't have all dependencies in the CMakeLists.txt files

3 participants