-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add apply_retention_mask and deprecate apply_boolean_mask
#23700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
4811dd5
29e55de
b82d751
e65f073
b91d046
2c2a981
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,12 +14,12 @@ | |
| #include <cudf/detail/nvtx/ranges.hpp> | ||
| #include <cudf/detail/row_operator/lexicographic.cuh> | ||
| #include <cudf/detail/sizes_to_offsets_iterator.cuh> | ||
| #include <cudf/detail/stream_compaction.hpp> | ||
| #include <cudf/join/join.hpp> | ||
| #include <cudf/join/sort_merge_join.hpp> | ||
| #include <cudf/lists/lists_column_view.hpp> | ||
| #include <cudf/null_mask.hpp> | ||
| #include <cudf/sorting.hpp> | ||
| #include <cudf/stream_compaction.hpp> | ||
| #include <cudf/table/table_view.hpp> | ||
| #include <cudf/types.hpp> | ||
| #include <cudf/utilities/error.hpp> | ||
|
|
@@ -648,7 +648,8 @@ void sort_merge_join::preprocessed_table::apply_nonnull_filter(cuda::stream_ref | |
| "Something went wrong while dropping nulls in the unprocessed tables"); | ||
| bool_mask->set_null_mask(_validity_mask.value(), _num_nulls.value(), stream); | ||
|
|
||
| _null_processed_table = apply_boolean_mask(_table_view, *bool_mask, stream, temp_mr); | ||
| _null_processed_table = | ||
| detail::apply_mask(_table_view, *bool_mask, detail::mask_type::RETENTION, stream, temp_mr); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Curious, why go to directly to the lower-level implementation rather than
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same reason as Parquet but happy to revert it here as not parquet related per se |
||
| _null_processed_table_view = _null_processed_table.value()->view(); | ||
| } | ||
|
|
||
|
|
||
|
igorpeshansky marked this conversation as resolved.
|
Uh oh!
There was an error while loading. Please reload this page.