-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Handle int64 strings offsets in cudf::byte_cast API #23725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1a3593a
Handle large strings offsets in cudf::byte_cast API
davidwendt d316170
Merge branch 'main' into ls-byte-cast
davidwendt c9ec30f
Merge branch 'main' into ls-byte-cast
davidwendt 320226c
Merge branch 'main' into ls-byte-cast
davidwendt 45a45f2
Merge branch 'main' into ls-byte-cast
davidwendt 5f6478c
Merge branch 'main' into ls-byte-cast
davidwendt b1c4ba0
Merge branch 'main' into ls-byte-cast
davidwendt bf9d22c
size_type to int32_t
davidwendt 399f50e
Merge branch 'main' into ls-byte-cast
davidwendt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: What happens if the string offsets are too large to cast into INT32?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the check on line 125 ensures all the offsets values are less than max(int32).
Probably should change
max(size_type)tomax(int32)there until large lists are supported.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.