Skip to content

Remove deprecated arrow_filter_policy alias - #24203

Open
PointKernel wants to merge 1 commit into
NVIDIA:mainfrom
PointKernel:remove-deprecated-arrow-filter-policy
Open

PointKernel wants to merge 1 commit into
NVIDIA:mainfrom
PointKernel:remove-deprecated-arrow-filter-policy

Conversation

@PointKernel

Copy link
Copy Markdown
Member

Description

This PR removes the deprecated cudf::arrow_filter_policy<Hash> alias in favor of cudf::arrow_bloom_filter_policy<Key, Hash>. It was deprecated in 26.10 by #23671 and has no remaining users in libcudf.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@PointKernel PointKernel added libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 16, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@PointKernel
PointKernel marked this pull request as ready for review September 16, 2026 18:45
@PointKernel
PointKernel requested a review from a team as a code owner September 16, 2026 18:45
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: dbb75bfa-6803-4340-aa52-13c7f4434a60

📥 Commits

Reviewing files that changed from the base of the PR and between 8f02800 and 705403e.

📒 Files selected for processing (1)
  • cpp/include/cudf/reduction/bloom_filter.cuh
💤 Files with no reviewable changes (1)
  • cpp/include/cudf/reduction/bloom_filter.cuh

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Removed
    • Removed the deprecated cudf::arrow_filter_policy<Hash> alias.
    • Use the supported cudf::arrow_bloom_filter_policy<Key, Hash> policy instead.

Walkthrough

The change removes the deprecated cudf::arrow_filter_policy<Hash> alias. The supported cudf::arrow_bloom_filter_policy<Key, Hash> policy remains available.

Changes

Bloom filter policy cleanup

Layer / File(s) Summary
Remove deprecated policy alias
cpp/include/cudf/reduction/bloom_filter.cuh
Removes the deprecated cudf::arrow_filter_policy<Hash> alias and its deprecation guidance. The supported Arrow bloom filter policy remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 70540

The deprecated alias removal matches the supported API transition and no unresolved merge-blocking issue is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: removal of the deprecated arrow_filter_policy alias.
Description check ✅ Passed The description directly explains the removal of cudf::arrow_filter_policy<Hash>, its replacement, deprecation history, and related validation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant