-
Notifications
You must be signed in to change notification settings - Fork 652
Update Dask RF to use the new distributed algo #8466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chyunsu3
wants to merge
17
commits into
NVIDIA:main
Choose a base branch
from
chyunsu3:distributed_rf_dask
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
507a763
cuml#8394 squashed
chyunsu3 74119ad
Update Dask RF to use the new distributed algo
chyunsu3 9f88d21
Merge branch 'main' into distributed_rf_dask
chyunsu3 966fd32
Merge branch 'main' into distributed_rf_dask
chyunsu3 c041409
Merge remote-tracking branch 'origin/main' into distributed_rf_dask
chyunsu3 7891881
Deprecate n_streams, ignore_empty_partitions, broadcast_data
chyunsu3 7dfde41
Move comms.init inside try block
chyunsu3 634aafe
Update pytests
chyunsu3 89b8ea0
Fix warnings
chyunsu3 62276dd
Use 64-bit int to store global row count
chyunsu3 ca9e031
Ensure that at least one future exists in fit()
chyunsu3 628e25e
Synchronize docstrings
chyunsu3 799b7c8
Merge remote-tracking branch 'origin/main' into distributed_rf_dask
chyunsu3 8f2b553
Add unit test test_rf_regression_nan_on_one_worker
chyunsu3 41f0df4
Validate inputs before fit()
chyunsu3 6cba38d
Coerce n_streams to stream pool size
chyunsu3 96cb72b
Move cuml_rf_allreduce_validation_status() to ML::detail
chyunsu3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* | ||
| * SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include <raft/core/comms.hpp> | ||
| #include <raft/core/handle.hpp> | ||
| #include <raft/core/resource/comms.hpp> | ||
| #include <raft/core/resource/cuda_stream.hpp> | ||
|
|
||
| namespace ML::detail { | ||
|
|
||
| inline void cuml_rf_allreduce_validation_status(const raft::handle_t& handle, | ||
| const int* local_status, | ||
| int* global_status) | ||
| { | ||
| auto const& comm = raft::resource::get_comms(handle); | ||
| cudaStream_t stream = raft::resource::get_cuda_stream(handle); | ||
| comm.allreduce(local_status, global_status, 1, raft::comms::op_t::MAX, stream); | ||
| RAFT_EXPECTS(comm.sync_stream(stream) == raft::comms::status_t::SUCCESS, | ||
| "Input validation status all-reduce failed"); | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| } // namespace ML::detail | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm putting this in a separate header. If this function had gone into
cuml/ensemble/randomforest.hpp, we'd need to includeraft/core/handle.hppand increate the compilation time.