chore: trigger NVSkills CI for cuopt-routing-api-python - #1676
Conversation
|
/nvskills-ci |
📝 WalkthroughWalkthroughThe cuOpt routing skill package received updated documentation metadata, six evaluation cases, benchmark results and methodology, skill-card content, and in-toto attestation data. ChangesRouting skill publication refresh
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
CI Test Summary⏭️ All 5 test job(s) skipped. |
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-routing-api-python/BENCHMARK.md`:
- Line 37: Correct the Codex overall uplift from +22 points to +23 points in
skills/cuopt-routing-api-python/BENCHMARK.md at lines 37-37 and
skills/cuopt-routing-api-python/skill-card.md at lines 70-70, then regenerate
skill.oms.sig to keep the benchmark artifacts consistent.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8f7b3efa-2b32-4796-999d-6d15f667fc1c
📒 Files selected for processing (3)
skills/cuopt-routing-api-python/BENCHMARK.mdskills/cuopt-routing-api-python/skill-card.mdskills/cuopt-routing-api-python/skill.oms.sig
| Underlying evaluation signals used in this run: | ||
| | Measure | Claude Code (Baseline → Skill Uplift) | Codex (Baseline → Skill Uplift) | | ||
| |---|---:|---:| | ||
| | Overall | 52% → 95% (+43 points) | 60% → 83% (+22 points) | |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Keep the Codex uplift consistent across both reports.
The documented formula is skill score - baseline score. The Codex result is 83% - 60% = +23 points, not +22 points. Correct both rows and regenerate skill.oms.sig.
skills/cuopt-routing-api-python/BENCHMARK.md#L37-L37: change the Codex overall uplift from+22 pointsto+23 points.skills/cuopt-routing-api-python/skill-card.md#L70-L70: change the matching summary value from+22 pointsto+23 points.
Proposed correction
- | Overall | 52% → 95% (+43 points) | 60% → 83% (+22 points) |
+ | Overall | 52% → 95% (+43 points) | 60% → 83% (+23 points) |📍 Affects 2 files
skills/cuopt-routing-api-python/BENCHMARK.md#L37-L37(this comment)skills/cuopt-routing-api-python/skill-card.md#L70-L70
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-routing-api-python/BENCHMARK.md` at line 37, Correct the Codex
overall uplift from +22 points to +23 points in
skills/cuopt-routing-api-python/BENCHMARK.md at lines 37-37 and
skills/cuopt-routing-api-python/skill-card.md at lines 70-70, then regenerate
skill.oms.sig to keep the benchmark artifacts consistent.
|
/ok to test bf0fe85 |
|
/ok to test 22b6e5e |
|
/ok to test 7bccfef |
A single eval gives the NVSkills Tier 3 live-agent evaluation almost no signal about the skill. Add six cases covering areas the skill documents but the existing eval does not exercise: solution status codes and the get_error_message / get_infeasible_orders triage path, add_capacity_dimension, set_pickup_delivery_pairs versus add_order_precedence, the explicit float32/int32 dtype requirement, the compute_waypoint_sequence in-place mutation gotcha, and the fact that routing has no C API. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
/nvskills-ci |
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/cuopt-routing-api-python/BENCHMARK.md`:
- Line 40: Update the Claude Code Discoverability uplift from “+71 points” to
“+72 points” in skills/cuopt-routing-api-python/BENCHMARK.md lines 40-40 and the
matching entry in skills/cuopt-routing-api-python/skill-card.md lines 73-73;
then regenerate skills/cuopt-routing-api-python/skill.oms.sig to reflect both
publication changes.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 0737cebc-34f9-4096-8204-0fddc0119e51
📒 Files selected for processing (3)
skills/cuopt-routing-api-python/BENCHMARK.mdskills/cuopt-routing-api-python/skill-card.mdskills/cuopt-routing-api-python/skill.oms.sig
🚧 Files skipped from review as they are similar to previous changes (1)
- skills/cuopt-routing-api-python/skill.oms.sig
| | Overall | 54% → 91% (+37 points) | 60% → 86% (+26 points) | | ||
| | Security | 100% → 100% (±0 points) | 100% → 100% (±0 points) | | ||
| | Correctness | 77% → 91% (+14 points) | 80% → 100% (+20 points) | | ||
| | Discoverability | 21% → 93% (+71 points) | 50% → 88% (+38 points) | |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Correct the Discoverability uplift in both publication artifacts.
Both rows show 21% → 93% (+71 points). The correct uplift is +72 points.
skills/cuopt-routing-api-python/BENCHMARK.md#L40-L40: change the Claude Code Discoverability uplift to+72 points.skills/cuopt-routing-api-python/skill-card.md#L73-L73: change the matching Discoverability uplift to+72 points.
Regenerate skills/cuopt-routing-api-python/skill.oms.sig after updating both reports.
📍 Affects 2 files
skills/cuopt-routing-api-python/BENCHMARK.md#L40-L40(this comment)skills/cuopt-routing-api-python/skill-card.md#L73-L73
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/cuopt-routing-api-python/BENCHMARK.md` at line 40, Update the Claude
Code Discoverability uplift from “+71 points” to “+72 points” in
skills/cuopt-routing-api-python/BENCHMARK.md lines 40-40 and the matching entry
in skills/cuopt-routing-api-python/skill-card.md lines 73-73; then regenerate
skills/cuopt-routing-api-python/skill.oms.sig to reflect both publication
changes.
|
/ok to test 14d7093 |
|
/merge |
Trivial blank-line addition after SKILL.md frontmatter to trigger NVSkills CI — fetch updated skill card and benchmark for
cuopt-routing-api-python.