Add a skill for evolving skills or adding new skills based on interaction#952
Add a skill for evolving skills or adding new skills based on interaction#952rgsl888prabhu wants to merge 11 commits intoNVIDIA:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…public into add_skill_evolution
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a Skill Evolution framework: registers a new plugin and rule, adds comprehensive skill-evolution documentation and workflow, updates agent docs and validation docs, and inserts evolution hooks into existing skills and LP/MILP guidance. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/skill-evolution/SKILL.md`:
- Line 84: Add language identifiers to the two fenced code blocks in SKILL.md
that currently lack them: locate the fence under the "Skill update proposal:"
block and the fence under the "Skill insight (unscored):" block and change the
opening triple backticks from ``` to ```text so both code blocks are labeled
(for example, use the "text" tag) to satisfy markdownlint MD040.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ddc77017-3ae3-4df1-827c-9bbec706998f
📒 Files selected for processing (10)
.claude-plugin/marketplace.json.claude/CLAUDE.md.cursor/rules/skill-evolution.mdcAGENTS.mdagents/AGENTS.mdagents/AGENTS.mdci/README.mdskills/cuopt-user-rules/SKILL.mdskills/lp-milp-formulation/SKILL.mdskills/skill-evolution/SKILL.md
|
|
||
| The user may approve, decline, or defer for offline reflection. | ||
|
|
||
| ## Phase 3: Offline reflection |
There was a problem hiding this comment.
Few questions:
- For training the agent should have a clear context for each new prompt.
- The agent has seen the ground truths and would be jumping to inference without clearing context. I think we need state it explicitly and check that it works otherwise it may not be possible to do in the same active session.
- I think we need an evaluate.py that sets up the train pipeline. I don't think it can go over a dataset and understand what is train and test with the skill only. You can take a look at: https://github.com/karpathy/autoresearch/blob/master/prepare.py
- Should we provide a parser.py? The data is either in json or csv for outbound skill refinement: https://github.com/NVIDIA/cuopt-examples/tree/main/cuopt-agent/cuopt_agent/data/max_supply_what_ifs/eval
There was a problem hiding this comment.
I am currently working on eval part where I will try to evolve skill based on industry or dataset and then run again with updated ones. And also run this against the optmath and other dataset to see if it provides better performance.
There was a problem hiding this comment.
@hlinsen I agree, evaluation and evolution script needs to be separate. There is a on going discussion on how to tackle this, may be we can work on this as follow-up.
Description
The new skill will try to propose a change or new skills so that it can capture generic patterns to help next developer
Checklist