feat(lingbot): add selectable WebRTC presets#375
Open
gtong-nv wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
Collaborator
Author
|
/ok to test 3b4fbfe |
Contributor
Comment on lines
1331
to
+1338
| else (current.text_events if current is not None else None) | ||
| ) | ||
| self._pending_session_input = LingbotSessionInput( | ||
| preset_id=( | ||
| session_input.preset_id | ||
| if session_input.preset_id is not None | ||
| else (current.preset_id if current is not None else None) | ||
| ), |
Contributor
There was a problem hiding this comment.
After a user selects a preset, this merge keeps the old preset_id on later /api/session/input updates that omit preset_id, such as a manual prompt, image, or event-catalog edit. The scene can then return input_source: "preset" and the old active_preset_id even though the active inputs are now user-provided, so the picker marks the wrong preset as selected and the session metadata no longer describes the scene.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.