You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted in this alpasim issue, our omnidreams-alpasim integration release was missing the Dockerfile.alpasim file needed for building the alpasim-compatible image.
This MR:
Adds the missing file, which generates python wheels in a temporary container and copies them into a minimal runtime image.
Fixes a missing declaration in integrations/omnidreams/ludus-renderer/pyproject.toml, which caused built wheels to not work out-of-tree.
Is not a full resolution to the user-reported issue as there is a minor adjustment + a dataset fixup left on Alpasim side.
This PR adds the missing Dockerfile.alpasim for building an alpasim-compatible image using a multi-stage build, and fixes the ludus-renderer wheel packaging to include previously excluded .inl header files in the framework subdirectory.
New Dockerfile.alpasim: Uses FLASHDREAMS_BASE_IMAGE as both the build and runtime base. The builder stage installs flashdreams-omnidreams (and its workspace dependencies) non-editably into a versioned venv at /opt/flashdreams, which is then copied verbatim into the runtime image with the absolute path preserved so shebang lines and linker paths remain valid.
pyproject.toml fix: Adds _cpp/cudaraster/framework/**/*.inl to [tool.setuptools.package-data], completing the set of C++ source glob patterns for the framework subdirectory. Without this, JIT-compiled extension builds from an installed wheel would fail to locate inline definitions.
Confidence Score: 5/5
Safe to merge — both changes are well-scoped additions with no correctness regressions.
The Dockerfile follows a sensible multi-stage pattern, keeps the venv at a fixed absolute path to avoid broken shebangs, and correctly uses --locked and --no-editable. The pyproject.toml change is a targeted one-line addition that completes an existing glob family. The only open item (dev-dependency bloat via uv sync without --no-group) was already surfaced in a prior review thread and is a size concern, not a correctness issue.
No files require special attention.
Important Files Changed
Filename
Overview
docker/Dockerfile.alpasim
New multi-stage Dockerfile that builds a venv with non-editable wheels and copies it into the runtime image; structure is sound, though uv sync without --no-dev/--no-group (already noted in a previous thread) is the main open concern.
Adds the missing _cpp/cudaraster/framework/**/*.inl glob to package-data, completing the existing hpp/cpp/h pattern set and fixing out-of-tree wheel installs that need these inline headers for JIT compilation.
One small issue before merge: docker/Dockerfile.alpasim defaults to FLASHDREAMS_BASE_IMAGE=flashdreams-base:local, but the existing Docker docs build the base image as flashdreams:local:
One small issue before merge: docker/Dockerfile.alpasim defaults to FLASHDREAMS_BASE_IMAGE=flashdreams-base:local, but the existing Docker docs build the base image as flashdreams:local:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in this alpasim issue, our omnidreams-alpasim integration release was missing the
Dockerfile.alpasimfile needed for building the alpasim-compatible image.This MR:
integrations/omnidreams/ludus-renderer/pyproject.toml, which caused built wheels to not work out-of-tree.