Standardize workspace on headless OpenCV#383
Conversation
Signed-off-by: Haoran Qian <haoran@hust.edu.cn>
|
Hi @Arison591, thanks for the PR. Can you mark it "Ready for review" so that we can land it? |
Greptile SummaryThis PR removes the unused
Confidence Score: 4/5Safe to merge for workspace users; the standalone ludus-renderer lockfile carries an unverified OpenCV major version bump worth a quick sanity-run before tagging a release. All workspace-level changes are clean metadata removals backed by a well-designed policy test. The one gap is that the standalone lockfile resolves to opencv-python-headless 5.0.0.93 — a major version jump — and the ludus-renderer dev test suite was not run against it. integrations/omnidreams/ludus-renderer/uv.lock — the standalone lock resolves opencv-python-headless to 5.0.0.93; worth running the ludus-renderer dev pytest suite against it before merging if those tests touch cv2. Important Files Changed
|
|
/ok to test 55980b2 |
Summary
opencv-pythondistributionopencv-python-headlessWhy
The
opencv-pythonandopencv-python-headlessdistributions install the samecv2namespace and should not coexist in one environment. FlashDreams already standardizes on the headless distribution for server and CI use, but FlashVSR and ludus-renderer's development extra could still bring the GUI distribution into the shared workspace.FlashVSR does not import
cv2directly, so its extra direct dependency is unnecessary. The renderer's development dependency still provides the same Python API through the headless build.This does not add a new third-party component:
opencv-python-headlessis already used throughout the workspace and recorded inTHIRD-PARTY-NOTICES.Validation
PYTHONPATH=flashdreams python -m pytest tests/test_dependency_policy.py -m ci_cpu -q— 1 passeduv lock --check— passeduv lock --check --project integrations/omnidreams/ludus-renderer— passedruff check tests/test_dependency_policy.py— passedruff format --check tests/test_dependency_policy.py— passeduvx ty check tests/test_dependency_policy.py— passeduvx --from reuse reuse lint— REUSE 3.3 compliant, 508/508 files coveredGPU inference was not run because this change only affects dependency metadata and its CPU policy test.
The commit is signed off under the Developer Certificate of Origin.