Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated year for MKL GPG #477

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Updated year for MKL GPG #477

merged 2 commits into from
Oct 26, 2023

Conversation

kristofkessler
Copy link
Contributor

@kristofkessler kristofkessler commented Oct 25, 2023

Pull Request Description

Fixes #475

Author Checklist

  • Updated documentation (pydocmd generate) if any docstrings have been modified
  • Passes all unit tests

@samcmill
Copy link
Collaborator

Thanks for the fix.

Can you please also update the affected tests in test/test_mkl.py?

@kristofkessler kristofkessler marked this pull request as draft October 26, 2023 07:31
@kristofkessler
Copy link
Contributor Author

Thanks for the fix.

Can you please also update the affected tests in test/test_mkl.py?

I updated test/test_mkl.py. Local pytest is successful.

One thing that could be considered: Should the MKL version be updated as well? If so, then this would probably be something for a separate pull request.

@kristofkessler kristofkessler marked this pull request as ready for review October 26, 2023 08:55
@samcmill
Copy link
Collaborator

One thing that could be considered: Should the MKL version be updated as well? If so, then this would probably be something for a separate pull request.

MKL has been rebranded to oneMKL, so presumably quite a bit would need to change. That raises the question of whether backwards compatibility with the "old" MKL should be retained or not?

@samcmill samcmill merged commit 5603329 into NVIDIA:master Oct 26, 2023
19 checks passed
@kristofkessler kristofkessler deleted the patch-1 branch November 21, 2023 14:09
@kristofkessler
Copy link
Contributor Author

Would it be possible to create a new release of hpc container maker including this bugfix and make it available on pypi? Thanks.

@samcmill
Copy link
Collaborator

Yes. If not tomorrow, then soon after Thanksgiving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPG error with MKL building block
2 participants