Omit misleading free IP count from fast path error#3703
Merged
behroozrafii merged 1 commit intoJul 21, 2026
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe ChangesFast-path error formatting
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
behroozrafii
force-pushed
the
behrooz/3384-misleading-free-ip-count
branch
from
July 20, 2026 21:18
68bb7f5 to
30eaae3
Compare
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bcavnvidia
reviewed
Jul 20, 2026
behroozrafii
force-pushed
the
behrooz/3384-misleading-free-ip-count
branch
from
July 20, 2026 22:20
30eaae3 to
1288205
Compare
Signed-off-by: Behrooz Rafii <brafii@nvidia.com>
behroozrafii
force-pushed
the
behrooz/3384-misleading-free-ip-count
branch
from
July 20, 2026 23:02
1288205 to
cce66ee
Compare
bcavnvidia
approved these changes
Jul 21, 2026
bcavnvidia
marked this pull request as ready for review
July 21, 2026 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-path machine-interface creation errors currently report
NetworkPrefix.num_free_ips: 0even when the number of available IPs was notcomputed. Because the DHCP discovery path does not request that computation,
the reported zero is only the field's default value and can mislead operators
into diagnosing address-pool exhaustion.
This change replaces the raw
Debugoutput with a concise list of segmentnames and IDs constructed directly in
create_fast_path. Each segment isreported as
<name> (<id>), retaining useful identification without exposinguncomputed fields such as
num_free_ips.Related issues
Fixes #3384
Type of Change
Breaking Changes
Testing
Commands run:
cargo fmt --all -- --checkcargo check -p carbide-api-db --libcargo test -p carbide-api-db --lib --no-runThe full
cargo test -p carbide-api-db --libsuite was also attempted. Itcould not complete because database-backed tests require
DATABASE_URL, whichis not configured on this host. Before the suite reported the database setup
failures, 81 tests passed.
Additional Notes
This is a diagnostic-only change. IP allocation behavior and free-IP
calculation are unchanged.