Fix RMS rack firmware completion state - #5028
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-08-14 23:30:36 UTC | Commit: 1212780 |
Direct compute-tray firmware updates handled by RMS complete at the rack firmware layer. After RMS reported success, the machine controller incorrectly transitioned the host to CheckingFirmwareRepeatV2, causing a second firmware update through the legacy Redfish path. This duplicate attempt could fail with Invalid FW Package, leaving the host in FailedFirmwareUpgrade even though the RMS update had already succeeded.
This change treats a successful rack firmware update as the terminal state for the current host firmware scenario:
backport of #5019 to v2.1
Related issues
#2016
Type of Change