Skip to content

Fix RMS rack firmware completion state - #5028

Merged
nv-dmendoza merged 3 commits into
NVIDIA:release/v2.1from
anunna0:fix-rms-rack-firmware-completion-2.1
Aug 15, 2026
Merged

Fix RMS rack firmware completion state#5028
nv-dmendoza merged 3 commits into
NVIDIA:release/v2.1from
anunna0:fix-rms-rack-firmware-completion-2.1

Conversation

@anunna0

@anunna0 anunna0 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Direct compute-tray firmware updates handled by RMS complete at the rack firmware layer. After RMS reported success, the machine controller incorrectly transitioned the host to CheckingFirmwareRepeatV2, causing a second firmware update through the legacy Redfish path. This duplicate attempt could fail with Invalid FW Package, leaving the host in FailedFirmwareUpgrade even though the RMS update had already succeeded.
This change treats a successful rack firmware update as the terminal state for the current host firmware scenario:

Unassigned hosts return to Ready.
Assigned hosts return to Assigned/Ready.
The host reprovisioning request is cleared.
No second legacy firmware update is launched.

backport of #5019 to v2.1

Related issues

#2016

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

@anunna0
anunna0 requested a review from a team August 14, 2026 23:28
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5e9a16f1-a027-4ce3-9b77-5a264d99144f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-08-14 23:30:36 UTC | Commit: 1212780

@nv-dmendoza
nv-dmendoza merged commit d09fa7b into NVIDIA:release/v2.1 Aug 15, 2026
122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants