Use go to manage build image dependencies #138
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evan Lezar <[email protected]>
elezar
changed the title
elezar
requested review from
ArangoGutierrez and
klueska
and removed request for
ArangoGutierrez
ArangoGutierrez
approved these changes
Jul 9, 2024
| @@ -24,12 +24,6 @@ vVERSION := v$(VERSION:v%=%) | |||
| GOLANG_VERSION ?= 1.22.1 | |||
There was a problem hiding this comment.
Not for this PR, but we should bump this, as @klueska mentioned to be testing 1.22.4 on slack
|
|
||
| go 1.22.0 | ||
|
|
||
| toolchain go1.22.3 |
There was a problem hiding this comment.
Question: Does dependabot also bumps toolchain or just the go line bit?
|
Can we refresh this PR? I think it is still valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change manages tooling dependencies using go instead of relying on the k8s-test-infra image.
This allows for the image and tooling dependencies to be updated independently.
See also NVIDIA/k8s-device-plugin#798