Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deploying DRA to OpenShift #82

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

empovit
Copy link
Contributor

@empovit empovit commented Mar 7, 2024

  • Document the differences on OpenShift
  • Include useful setup scripts

@empovit empovit marked this pull request as ready for review March 7, 2024 13:13
@elezar elezar self-requested a review March 7, 2024 13:20
@elezar elezar self-assigned this Mar 7, 2024
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @empovit. I have some minor comments / questions here.

demo/clusters/openshift/README.md Outdated Show resolved Hide resolved
demo/clusters/openshift/README.md Outdated Show resolved Hide resolved
OpenShift generally requires more stringent security settings than Kubernetes. If you see a warning about security context constraints when deploying the DRA plugin, pass the following to the Helm chart, either via an in-line variable or a values file:

```yaml
kubeletPlugin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of scope: As a matter of interest, does it make sense to make something like this the default on Openshift?

Copy link
Contributor Author

@empovit empovit Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but this clause is currently in values.yaml. I'm not sure it's possible to use conditional statements there.

demo/clusters/openshift/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,21 @@
#!/usr/bin/env bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link these scripts in the README?

Copy link
Contributor Author

@empovit empovit Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. Actually I wasn't sure if the scripts were needed at all. Let's leave it as it is, anybody trying OpenShift will notice them, but it's important that they understand what the scripts do and why.

@elezar elezar requested a review from cdesiniotis March 7, 2024 13:28
@elezar
Copy link
Member

elezar commented Mar 7, 2024

/cc @cdesiniotis since he has more OpenShift experience than me.

@empovit empovit force-pushed the openshift-doc branch 2 times, most recently from 6bf7bac to c588614 Compare March 7, 2024 14:30
@empovit empovit marked this pull request as draft June 20, 2024 14:59
* Document the differences on OpenShift
* Include useful setup scripts

Signed-off-by: Vitaliy Emporopulo <[email protected]>
@empovit empovit marked this pull request as ready for review July 3, 2024 14:23
@empovit empovit marked this pull request as draft July 11, 2024 10:02
@kannon92
Copy link

kannon92 commented Sep 6, 2024

@klueska @elezar @cdesiniotis How can we go forward with this PR?

@klueska
Copy link
Collaborator

klueska commented Sep 6, 2024

Things are changing drastically for 1.31 (just as they did for the example driver). Once we have main updated with all of the changes for 1.31, we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants