Remove coreutils: devtmpfs handles /dev nodes #123
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes manual device node and symlink creation by relying on the kernel's devtmpfs filesystem and kata-agent to handle /dev setup automatically. This simplifies the codebase by eliminating custom implementations of core utilities.
Changes:
- Removed the
coreutilsmodule containinglnandmknodimplementations - Removed manual device node and symlink creation from
mount.rs - Removed the
mount_parsingfuzz target and its configuration - Added
#[ignore]attributes to dangerous tests that affect system state - Updated CI workflows to run ignored tests with
--include-ignoredflag
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/coreutils.rs | Removed entire module - no longer needed for device setup |
| src/main.rs | Removed coreutils module import |
| src/lib.rs | Removed coreutils from public module exports |
| src/mount.rs | Removed proc_symlinks() and device_nodes() functions, updated comments to reflect devtmpfs behavior, removed related tests |
| src/lockdown.rs | Added #[ignore] attributes to tests that permanently modify system state |
| fuzz/fuzz_targets/mount_parsing.rs | Removed obsolete fuzz target |
| fuzz/Cargo.toml | Removed mount_parsing target configuration |
| .github/workflows/static-checks.yaml | Added --include-ignored flag to run previously ignored tests in CI |
| .github/workflows/coverage.yaml | Added --include-ignored flag for coverage of ignored tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The kernel's devtmpfs (via mem.c driver) automatically creates /dev/null, /dev/zero, /dev/random, /dev/urandom when mounted. Symlinks (/dev/fd, /dev/stdin, etc.) are created by kata-agent. - Remove coreutils.rs (ln, mknod no longer needed) - Remove proc_symlinks() and device_nodes() from mount.rs - Remove mount_parsing fuzz target (no longer applicable) - Add #[ignore] to dangerous tests (module disable, power_off hook) - Add --include-ignored to CI workflows for safe runner execution Co-Authored-By: Zvonko Kaiser <zkaiser@nvidia.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
The kernel's devtmpfs (via mem.c driver) automatically creates /dev/null, /dev/zero, /dev/random, /dev/urandom when mounted. Symlinks (/dev/fd, /dev/stdin, etc.) are created by kata-agent.