release: Eliminate race condition #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR eliminates a race condition in the release workflow where parallel matrix jobs were attempting to create/update the same GitHub release concurrently, causing failures when one job locked the release during upload.
Changes:
- Refactored release creation to run in a dedicated job after all matrix builds complete
- Updated downstream job dependencies to wait for the new create-release job
- Bumped package version from 0.0.1 to 0.0.2
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Cargo.lock | Version bump to 0.0.2 for the new release |
| .github/workflows/release.yaml | Extracted release creation into a separate job that runs after matrix builds and updated job dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was a race condition - both matrix jobs (x86_64 and aarch64) were trying to create/update the same GitHub release concurrently. When one finishes first and creates the release, the second one fails because the release becomes "immutable" during the first upload.
Changes made:
1 Removed the release creation from the build-and-release matrix job
2 Added a new create-release job that:
Updated downstream job dependencies from build-and-release to create-release