Remove interp from primvar descriptor equality check #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerm-nv
changed the title
asluk
reviewed
Nov 15, 2022
pxr/imaging/hd/sceneDelegate.h
Outdated
| @@ -191,8 +191,7 @@ struct HdPrimvarDescriptor { | |||
| : name(name_), interpolation(interp_), role(role_), indexed(indexed_) | |||
| { } | |||
| bool operator==(HdPrimvarDescriptor const& rhs) const { | |||
There was a problem hiding this comment.
we'll want to add a test, similar to what @nvidia-jomiller did in PixarAnimationStudios#1807, that fails without the change, and passes with it. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Changing primvar interpolation causes
UsdImagingPrimAdapter::_MergePrimvarto insert a duplicate into the descriptor vector. Removed the interp check from the==operator so that it finds the existing primvar.Fixes Issue(s)