Skip to content

Conversation

@jlheflin
Copy link
Contributor

@jlheflin jlheflin commented Oct 5, 2025

Is this pull request associated with an issue(s)?
Closes #89

Description
Adds in reporting of Z and N values for the associated basis set and atom modules. Also, this is my first pull request with the implemented pre-commit hooks, so I just wanted to make sure I was using it correctly.

TODOs

  • Add in reporting of Z to basis set std::out_of_range errors
  • Add in reporting of Z and mass number std::out_of_range errors
  • Adjust tests in response to changes
  • Make changes congruent (I have varying fixes, each input variable should be assigned to a new variable when converted to a string)

@jlheflin jlheflin changed the title shortened python line Add Z reporting to error messages Oct 5, 2025
@jlheflin jlheflin self-assigned this Oct 5, 2025
ryanmrichard
ryanmrichard previously approved these changes Oct 6, 2025
Copy link
Member

@ryanmrichard ryanmrichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jlheflin jlheflin marked this pull request as ready for review October 6, 2025 04:26
@jwaldrop107 jwaldrop107 enabled auto-merge (squash) October 8, 2025 19:49
@jwaldrop107 jwaldrop107 merged commit e8c3c6a into master Oct 8, 2025
5 checks passed
@jwaldrop107 jwaldrop107 deleted the report_z branch October 8, 2025 20:59
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2025

🚀 [bumpr] Bumped!
New version:v1.1.7
Changes:v1.1.6...v1.1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More informative error messages for basis set modules

4 participants