PythonWrapper::unwrap Patch
#366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmrichard
approved these changes
Jun 9, 2025
Member
ryanmrichard
left a comment
ryanmrichard
left a comment
There was a problem hiding this comment.
Nice find! That's a heck of a subtle bug.
Member
Author
|
🚀 [bumpr] Bumped! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No
Description
When unwrapping an object wrapped by a
PythonWrapperto a reference, the recast python object is copied into ananybuffer. This buffer persists on thePythonWrapperand is checked on successive calls tounwrapto avoid repetitious effort. If the previous type being cast to isn't lossless when copied (e.g. casting aninttobool), the value stored in the buffer isn't sufficient and the underlying object needs to be reinterpreted again. This patch checks that the stored type is consistent with the requested return type, and triggers the recasting if not.