-
Notifications
You must be signed in to change notification settings - Fork 2
DFT Notes #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFT Notes #44
Conversation
|
@jwaldrop107, so the pre-commit I have installed locally adds a blank line to the end of the file, but the pre-commit on GitHub seems to not want it there (as long as the file ends in a newline character I don't really care if it's there or not). How do I proceed? |
|
@ryanmrichard when I run the pre-commit hooks locally, I'm seeing the same issue that's being returned in the actions, which is an extra whitespace character at the end of docs/README.md line 17. Maybe try uninstalling the pre-commit hooks, check that your config file is the most recent, and then reinstall the hooks. |
|
I checked pre-commit-config repo was up to date, deleted my virtual environment, reinstalled pre-commit, ran: (found that here) in the SCF repo. Then ran: To reinstall the hooks and get the same behavior (adds the whitespace back in). FWIW, my config file: |
|
🚀 [bumpr] Bumped! |
Is this pull request associated with an issue(s)?
No.
Description
Adds some notes that walk through recasting DFT as a sparse map problem. Such a problem should map better to tensor algebra.
TODOs
None. R2g.