Print Precision Options #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmrichard
approved these changes
Mar 7, 2025
Member
ryanmrichard
left a comment
ryanmrichard
left a comment
There was a problem hiding this comment.
This is a much better solution than to_string. I was running into a different problem where I wanted to change what's being printed based on the log level. I think that could be accomplished by overloading add_to_stream (you don't have to do it now, I'm just pointing it out in case it comes up later).
Member
Author
|
🚀 [bumpr] Bumped! New version:v0.0.49 Changes:v0.0.48...v0.0.49 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As is, stream output for classes derived from
PolymorphicBasefirst converts to a string then adds the string to the stream output. This behavior prevents controlling the print precision of floating point values as they never see options likestd::fixedorstd::setprecision. This PR adds theadd_to_streammethod as an intermediate step that derived classes can use to more directly interact with the output stream, but defaults to the existing behavior for anything that doesn't implementadd_to_stream_.