Add proper name to find Eigen installation #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwaldrop107
approved these changes
Jun 30, 2025
Member
|
🚀 [bumpr] Bumped! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
CMaize defaults to using the provided identifier for
cmaize_find*_dependencycalls when callingfind_package(). The name provided for Eigen here iseigen, but the installation is actually under directories namedeigen3. The provided name has to be fairly exact for CMake to find the installed package. This PR fixes the name so that an existing Eigen installation is able to be found and used.The Eigen installation references the
eigen3subdirectories starting here. The config search mode used infind_package()in CMaize is case insensitive, so I usedEigen3to match the project name for Eigen (here).TODOs