Load static JSON file from local disk each time#254
Open
allthesignals wants to merge 1 commit intoNYCPlanning:developfrom
Open
Load static JSON file from local disk each time#254allthesignals wants to merge 1 commit intoNYCPlanning:developfrom
allthesignals wants to merge 1 commit intoNYCPlanning:developfrom
Conversation
Contributor
|
@allthesignals Thanks for this! We're hopefully going to revisit layers-api soon so we'll definitely take this into account. I'm going to leave this hanging out as Open for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #253 by loading the style.json from local disk each time the route is called.
There may still be other memory leak issues throughout the app wherever
style.jsonis imported, but this addresses the biggest concern...