Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zero-copy writes for the multiplexer #395

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Mar 9, 2025

closes #394

Note that this likely won't make any difference until #369 and #344 because the current implementation forces many small reads which negate much of the benefit here. Since we benchmark both sides of the connection, the benchmark won't improve much either until we can get the read buffer size a bit more aligned with the use case.

On 1 MiB message this will make quite a bit of a difference for a write op even if its only a small part of the whole stack:
Screenshot 2025-03-08 at 4 11 37 PM

Copy link

codspeed-hq bot commented Mar 9, 2025

CodSpeed Performance Report

Merging #395 will not alter performance

Comparing bdraco:zerocopy_writes (85f254a) with main (506c0eb)

Summary

✅ 4 untouched benchmarks

@bdraco
Copy link
Contributor Author

bdraco commented Mar 9, 2025

Marking as draft to wait for #369 and #344 since it will change the dynamic

@bdraco bdraco marked this pull request as draft March 9, 2025 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core multiplexer writer can avoid bytes join on write
1 participant