Skip to content

ci: add cargo fmt --check and cargo deny to CI - #159

Merged
Nanle-code merged 5 commits into
Nanle-code:masterfrom
cyber-excel10:ci/add-fmt-and-deny
May 28, 2026
Merged

ci: add cargo fmt --check and cargo deny to CI#159
Nanle-code merged 5 commits into
Nanle-code:masterfrom
cyber-excel10:ci/add-fmt-and-deny

Conversation

@cyber-excel10

Copy link
Copy Markdown
Contributor

Closes #129

Changes

  • Added cargo fmt --all --check as a separate CI job to catch formatting issues
  • Added cargo deny check via EmbarkStudios/cargo-deny-action@v2 for advisory and license scanning
  • Added deny.toml at repo root with sensible defaults (version = 2 schema):
    • Advisories: known transitive issues via pinned ureq =2.7.1 are documented and ignored with comments
    • Licenses: explicit allowlist of permissive FOSS licenses + ring clarification for missing license field
    • Bans: duplicate versions warn, wildcards denied
    • Sources: crates.io only

Pre-existing issues fixed

  • Removed duplicate pub mod template; in src/utils/mod.rs (file doesn't exist, only templates.rs does)
  • Removed duplicate struct body in src/utils/horizon.rs that caused a parse error blocking cargo fmt
  • Auto-formatted benches/benchmarks.rs and tests/template_marketplace_test.rs via cargo fmt --all

All three CI jobs run in parallel for faster feedback.

@drips-wave

drips-wave Bot commented May 28, 2026

Copy link
Copy Markdown

@cyber-excel10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@cyber-excel10

Copy link
Copy Markdown
Contributor Author

Hi, @Nanle-code based on the failing Build, Test & Clippy job:

These build errors are pre-existing on main before this PR was opened. My PR only addresses issue #129 — adding cargo fmt --check and cargo deny to CI. The Rustfmt and Cargo Deny jobs that i added by this PR both pass successfully.

@Nanle-code
Nanle-code merged commit 30b0760 into Nanle-code:master May 28, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue 38: Add cargo fmt and cargo deny to CI

2 participants