ci: add cargo fmt --check and cargo deny to CI - #159
Merged
Conversation
|
@cyber-excel10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Hi, @Nanle-code based on the failing Build, Test & Clippy job: These build errors are pre-existing on main before this PR was opened. My PR only addresses issue #129 — adding cargo fmt --check and cargo deny to CI. The Rustfmt and Cargo Deny jobs that i added by this PR both pass successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129
Changes
cargo fmt --all --checkas a separate CI job to catch formatting issuescargo deny checkviaEmbarkStudios/cargo-deny-action@v2for advisory and license scanningdeny.tomlat repo root with sensible defaults (version = 2 schema):ureq =2.7.1are documented and ignored with commentsPre-existing issues fixed
pub mod template;insrc/utils/mod.rs(file doesn't exist, onlytemplates.rsdoes)src/utils/horizon.rsthat caused a parse error blockingcargo fmtbenches/benchmarks.rsandtests/template_marketplace_test.rsviacargo fmt --allAll three CI jobs run in parallel for faster feedback.