Fix 11356 - IDF Version Updater drops EIR function names

[kevin-moos]

Pull request overview

• Fixes IDFVersionUpdater drops EIR function names #11356

Description of the purpose of this PR

Fix a defect in CreateNewIDFUsingRulesV23_2_0.f90 in which EIR function names are dropped when updating COIL:HEATING:DX:VARIABLESPEED objects.
Fix a secondary defect in CreateNewIDFUsingRulesV23_2_0.f90 in which extra blank fields are added when updating COIL:HEATING:DX:VARIABLESPEED and COIL:COOLING:DX:VARIABLESPEED objects.

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
• If adding/removing any output files (e.g., eplustbl.*)
  • Update ..\scripts\Epl-run.bat
  • Update ..\scripts\RunEPlus.bat
  • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
  • Update ...github\workflows\energyplus.py

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[rraustad]

OK, I can see how updating CurArgs (the original total of Alphas and Numbers) while processing a complex object could confuse subsequent logic, especially for extensible objects. This looks like a good fix. I did not test but it looks like this will work.

[nrel-bot-2]

@kevin-moos it has been 28 days since this pull request was last updated.

[mitchute]

I tested this locally. Looks good.