Skip to content

Fix 9669 - Crash when running a simulation with MultiZoneWithoutDistribution and fan #11383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchute merged 2 commits into from
Jan 8, 2026
+1,053 −2
Merged

Fix 9669 - Crash when running a simulation with MultiZoneWithoutDistribution and fan #11383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
702e5ab
Fix 9669 - Crash when running a simulation with MultiZoneWithoutDistr…
kevin-moos Dec 19, 2025
34e0285
Add unit test AirflowNetwork_MultizoneWithoutDistributionAndFan
kevin-moos Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/EnergyPlus/AirflowNetwork/src/Solver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9049,7 +9049,7 @@ namespace AirflowNetwork {
}

for (AirLoopNum = 1; AirLoopNum <= NumPrimaryAirSys; ++AirLoopNum) {
if (DisSysNumOfCVFs == 0) {
if (DisSysNumOfCVFs == 0 || !distribution_simulated) {
Copy link
Collaborator

@rraustad rraustad Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix. I guess another way would be to make sure whatever array crashed (assuming that is what happened) was allocated? This is probably the easiest and cleanest fix, so this is good.

    CurrentModuleObject = "AirflowNetwork:Distribution:Component:Fan";
    DisSysNumOfCVFs = m_state.dataInputProcessing->inputProcessor->getNumObjectsFound(m_state, CurrentModuleObject);

I wonder if other components could cause the same type of crash? Maybe not since the AFN Coil component works in the unit test. For example:

AirflowNetwork:Distribution:Component:HeatExchanger
AirflowNetwork:Distribution:Component:TerminalUnit

Copy link
Collaborator

@mitchute mitchute Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. This looks OK. distribution_simulated is checked in a bunch of different places, so this is inline with what we're already doing.

continue;
}
for (FanNum = 1; FanNum <= DisSysNumOfCVFs; ++FanNum) {
Expand Down Expand Up @@ -9378,7 +9378,7 @@ namespace AirflowNetwork {

// Rewrite AirflowNetwork airflow rate
for (AirLoopNum = 1; AirLoopNum <= NumPrimaryAirSys; ++AirLoopNum) {
if (DisSysNumOfCVFs == 0) {
if (DisSysNumOfCVFs == 0 || !distribution_simulated) {
continue;
}
for (FanNum = 1; FanNum <= DisSysNumOfCVFs; ++FanNum) {
Expand Down
Loading
Loading