Skip to content

Conversation

@tanaya-mankad
Copy link
Collaborator

Pull request overview

Description of the purpose of this PR

The Coil representation in ASHRAE Standard 205 is agnostic of whether a coil is used for heating or cooling. Therefore, although other EnergyPlus Coil objects are under an umbrella of either Coil:Cooling:DX or Coil:Heating:DX, the ASHRAE205 coils will be labeled consistently in both the IDD and documentation as simply Coil:DX.

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@tanaya-mankad tanaya-mankad self-assigned this Dec 22, 2025
@tanaya-mankad tanaya-mankad added Documentation Related primarily on the LaTeX-based EnergyPlus documentation Defect Includes code to repair a defect in EnergyPlus labels Dec 22, 2025
Copy link
Collaborator

@rraustad rraustad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these are the only places with this text.

{B6A53F5D-DA44-4E8B-9A20-08E289389245}

Copy link
Collaborator

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Merging.

@mitchute mitchute merged commit 05cea34 into develop Jan 7, 2026
11 of 13 checks passed
@mitchute mitchute deleted the Fix-11382-205-coil-docs branch January 7, 2026 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus Documentation Related primarily on the LaTeX-based EnergyPlus documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ASHRAE205 coil performance object has inconsistent documentation

6 participants