Change NREL to NLR by mitchute · Pull Request #11404 · NatLabRockies/EnergyPlus

mitchute · 2026-01-23T04:48:05Z

Pull request overview

NREL has been renamed. This updates references in the repo accordingly.

Pull Request Author

Reviewer

mitchute

Walk through

mitchute · 2026-01-23T04:48:40Z

bin/EP-Launch-Lite/codesign.sh

 #!/bin/bash

 APP_NAME=EP-Launch-Lite
-IDENTIFIER="org.nrel.EnergyPlus.$APP_NAME"


@jmarrec FYI

I think you want a three piece component still, so org.nlr.EnergyPlus is good already

The bin/ stuff is already codesigned in the repo.

We might need to recodesign (just to update the component name), but probably don't care

mitchute · 2026-01-23T04:49:29Z

cmake/Install.cmake

 set(CPACK_PACKAGE_VENDOR "US Department of Energy")
 set(CPACK_IFW_PACKAGE_PUBLISHER "${CPACK_PACKAGE_VENDOR}")

-set(CPACK_PACKAGE_CONTACT "Edwin Lee <edwin.lee@nrel.gov>")


Updating to point to me. @nrel.gov remains, for now.

mitchute · 2026-01-23T04:50:20Z

datasets/ElectricityUSAEnvironmentalImpactFactors.idf

 ! United States Water Emission Fuel Factors are the combined thermoelectric and hydroelectric weighted
 ! averages from:
 !   Torcellini, Paul; Long, Nicholas; Judkoff, Ron; "Consumptive Water Use for U.S. Power Production";
-!      NREL Report No. TP-550-33905.  Golden, CO; 2003; http://www.nrel.gov/docs/fy04osti/33905.pdf;


Doc links do appear to forward, but they also have been update to point to the new nlr.gov domain.

mitchute · 2026-01-23T04:52:30Z

datasets/ResidentialACsAndHPsPerfCurves.idf

 !  Improved Modeling of Residential Air Conditioners and Heat Pumps for Energy Calculations
 !
 !  Technical Report
-!  NREL/TP-5500-56354


This is a grey area for me. It was NREL at the time, so I'm not sure how rigorous to be on these. (Productive) thoughts, anyone?

You do have a point that the report would have the previous link. Those reports won't be updated will they.

I suppose anything is possible, but at this point, I don't expect them to go back and republish the reports with the new branding.

mitchute · 2026-01-23T04:53:06Z

performance_tests/15zonePSZ.idf

-!***** National Renewable Energy Laboratory ("NREL") operated by Midwest *****
-!***** Research Institute for the U.S. Department of Energy ("DOE"). *****


The Alliance got a new name, too.

github-actions · 2026-01-23T05:11:25Z

⚠️ Regressions detected on macos-14 for commit `8ae3b9f`

Regression Summary

IDF: 1

github-actions · 2026-01-23T05:12:32Z

⚠️ Regressions detected on ubuntu-24.04 for commit `8ae3b9f`

Regression Summary

IDF: 1

rraustad · 2026-01-23T06:44:58Z

performance_tests/15zonePSZ.idf

 !***** The EnergyPlus Example File Generator ("EEFG") is provided by the *****
-!***** National Renewable Energy Laboratory ("NREL") operated by Midwest *****
-!***** Research Institute for the U.S. Department of Energy ("DOE"). *****
+!***** National Laboratory of the Rockies ("NREL") operated by Alliance for*****


I'll fix it. Thanks.

jmarrec · 2026-01-23T07:23:34Z

bin/EP-Launch-Lite/codesign.sh

 #!/bin/bash

 APP_NAME=EP-Launch-Lite
-IDENTIFIER="org.nrel.EnergyPlus.$APP_NAME"


The bin/ stuff is already codesigned in the repo.

We might need to recodesign (just to update the component name), but probably don't care

jmarrec · 2026-01-23T08:33:13Z

bin/EP-Launch-Lite/codesign.sh


 function ep_codesign() {
-  codesign -vvvv -s "Developer ID Application: National Renewable Energy Laboratory (K7JYVQJL7R)" \
+  codesign -vvvv -s "Developer ID Application: National Laboratory of the Rockies (K7JYVQJL7R)" \


Hum, did you generate a new codesign identity to match that?

No. We will need to do that.

Rolling back all codesign changes for now. That's future @jmarrec's problem 😉

jmarrec · 2026-01-23T08:34:52Z

doc/readthedocs/sphinx/auxiliary-programs/auxiliary-programs.rst

 Renewable Energy Laboratory.

-http://rredc.nrel.gov/solar/pubs/tmy2/
+http://rredc.nlr.gov/solar/pubs/tmy2/


http://rredc.nlr.gov/solar/pubs/tmy2/ does not exist.

http://rredc.nrel.gov/solar/pubs/tmy2/ does.

Both of these are broken now.

jmarrec · 2026-01-23T08:39:52Z

design/FY2018/NFP_PVWatts.md

 ## Testing/Validation/Data Sources ##

-The EnergyPlus implementation of PVWatts will be validated against the [PVWatts API](https://developer.nrel.gov/docs/solar/pvwatts-v5/), which was validated against measured PV performance data (see section 15 in the [PVWatts Manual](#pvwattsmanual)).
+The EnergyPlus implementation of PVWatts will be validated against the [PVWatts API](https://developer.nlr.gov/docs/solar/pvwatts-v5/), which was validated against measured PV performance data (see section 15 in the [PVWatts Manual](#pvwattsmanual)).


https://developer.nlr.gov/docs/solar/pvwatts-v5/ doesn't exist yet.

https://developer.nrel.gov/docs/solar/pvwatts-v5/ is actually 404... but the developer.nrel.gov is and endpoint at least.

Thanks. I'll change these back. I think all links are in the process of being migrated, so we can revisit later.

mitchute · 2026-01-23T20:39:20Z

Ready for review by anyone who wants. I'm open to suggestions on what to leave as-is.

github-actions · 2026-01-23T20:41:37Z

⚠️ Regressions detected on ubuntu-24.04 for commit `4a9a127`

Regression Summary

IDF: 1

github-actions · 2026-01-23T20:44:51Z

⚠️ Regressions detected on ubuntu-24.04 for commit `64cc662`

Regression Summary

IDF: 1

github-actions · 2026-01-23T20:47:24Z

⚠️ Regressions detected on macos-14 for commit `4a9a127`

Regression Summary

IDF: 1

github-actions · 2026-01-23T20:47:27Z

⚠️ Regressions detected on macos-14 for commit `64cc662`

Regression Summary

IDF: 1

github-actions · 2026-01-23T20:49:24Z

⚠️ Regressions detected on ubuntu-24.04 for commit `32ca7ff`

Regression Summary

IDF: 1

github-actions · 2026-01-23T20:53:46Z

⚠️ Regressions detected on macos-14 for commit `32ca7ff`

Regression Summary

IDF: 1

mitchute · 2026-01-25T00:05:24Z

I'm still tinkering here, but feel free to review/comment.

mitchute · 2026-01-26T17:27:47Z

Final issue for discussion here (I hope) - are there any objections to this commit 50ff178? We typically don't have licenses in the example files, and these are holdovers from when the reference building models were generated. People should be pulling those from the appropriate DOE site anyway if they want to use them, i.e. not here.

github-actions · 2026-01-26T17:45:49Z

⚠️ Regressions detected on ubuntu-24.04 for commit `089147f`

Regression Summary

ERR: 1
Table String Diffs: 1
IDF: 1

github-actions · 2026-01-26T17:51:19Z

⚠️ Regressions detected on macos-14 for commit `089147f`

Regression Summary

ERR: 1
Table String Diffs: 1
IDF: 1

rraustad · 2026-01-26T21:52:14Z

are there any objections to this commit 50ff178?

No objections.

mitchute · 2026-01-26T22:10:54Z

Thanks @rraustad and @jmarrec for the reviews. We will deal with the required code signing changes later. Merging.

first pass at changing nrel to nlr

5e31c64

mitchute requested a review from jmarrec January 23, 2026 04:48

mitchute commented Jan 23, 2026

View reviewed changes

mitchute added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Jan 23, 2026

mitchute requested a review from rraustad January 23, 2026 04:54

rraustad reviewed Jan 23, 2026

View reviewed changes

jmarrec reviewed Jan 23, 2026

View reviewed changes

mitchute added 3 commits January 23, 2026 13:16

update nrel links

31c3d14

rollback codesign changes for now

e0f6c96

rollback pvwatts url for now

d3581ef

mitchute added 6 commits January 24, 2026 15:34

rollback report name changes

9b084c1

Merge branch 'develop' into strike-out-nrel

5da3b9f

update alliance name in license [skip ci]

6ee859b

fix non-utf characters [skip ci]

da5e3e8

rollback all third-party changes [skip ci]

1cf940e

update email address [skip ci]

f70fafe

mitchute mentioned this pull request Jan 26, 2026

Fix Incorrect High Slat Angle Index #11405

Merged

25 tasks

remove legacy comments statements in example files

50ff178

minor touch-up [skip ci][decent_ci_skip]

0f5d06a

fix diffs, remove remaining legacy statements from example files

713fe39

mitchute merged commit bc3524d into develop Jan 26, 2026
11 checks passed

mitchute deleted the strike-out-nrel branch January 26, 2026 22:11

		!*** National Renewable Energy Laboratory ("NREL") operated by Midwest ***
		!*** Research Institute for the U.S. Department of Energy ("DOE"). ***

Conversation

mitchute commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Pull Request Author

Reviewer

Uh oh!

mitchute left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmarrec Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchute Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on macos-14 for commit 8ae3b9f

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 8ae3b9f

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mitchute commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 4a9a127

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 64cc662

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on macos-14 for commit 4a9a127

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on macos-14 for commit 64cc662

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on ubuntu-24.04 for commit 32ca7ff

Uh oh!

github-actions bot commented Jan 23, 2026

⚠️ Regressions detected on macos-14 for commit 32ca7ff

Uh oh!

mitchute commented Jan 25, 2026

Uh oh!

mitchute commented Jan 23, 2026 •

edited

Loading

jmarrec Jan 23, 2026 •

edited

Loading

mitchute Jan 23, 2026 •

edited

Loading

⚠️ Regressions detected on macos-14 for commit `8ae3b9f`

⚠️ Regressions detected on ubuntu-24.04 for commit `8ae3b9f`

⚠️ Regressions detected on ubuntu-24.04 for commit `4a9a127`

⚠️ Regressions detected on ubuntu-24.04 for commit `64cc662`

⚠️ Regressions detected on macos-14 for commit `4a9a127`

⚠️ Regressions detected on macos-14 for commit `64cc662`

⚠️ Regressions detected on ubuntu-24.04 for commit `32ca7ff`

⚠️ Regressions detected on macos-14 for commit `32ca7ff`

⚠️ Regressions detected on ubuntu-24.04 for commit `089147f`

⚠️ Regressions detected on macos-14 for commit `089147f`